Skip to content

Commit 25aa21a

Browse files
committed
Analysis: Resolve composable naming lint warning on loaded state
Warning Message: "Composable functions with a return type should start with a lowercase letter" Explanation: "@composable functions without a return type should use similar naming to classes, starting with an uppercase letter and ending with a noun. @composable functions with a return type should be treated as normal Kotlin functions, starting with a lowercase letter." ------------------------------------------------------------------------ Renaming the 'LoadedState(...)' composable function, that has a return type, to the lowercase letter 'loadedState(...)' fixes this warning.
1 parent 39e0dff commit 25aa21a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

WordPress/src/main/java/org/wordpress/android/ui/jetpackplugininstall/fullplugin/onboarding/JetpackFullPluginInstallOnboardingDialogFragment.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import org.wordpress.android.ui.jetpackplugininstall.fullplugin.onboarding.Jetpa
2929
import org.wordpress.android.ui.jetpackplugininstall.fullplugin.onboarding.JetpackFullPluginInstallOnboardingViewModel.ActionEvent.OpenInstallJetpackFullPlugin
3030
import org.wordpress.android.ui.jetpackplugininstall.fullplugin.onboarding.JetpackFullPluginInstallOnboardingViewModel.ActionEvent.OpenTermsAndConditions
3131
import org.wordpress.android.ui.jetpackplugininstall.fullplugin.onboarding.JetpackFullPluginInstallOnboardingViewModel.UiState
32-
import org.wordpress.android.ui.jetpackplugininstall.fullplugin.onboarding.compose.state.LoadedState
32+
import org.wordpress.android.ui.jetpackplugininstall.fullplugin.onboarding.compose.state.loadedState
3333
import org.wordpress.android.util.WPUrlUtils
3434
import org.wordpress.android.util.extensions.exhaustive
3535
import org.wordpress.android.util.extensions.onBackPressedCompat
@@ -78,7 +78,7 @@ class JetpackFullPluginInstallOnboardingDialogFragment : DialogFragment() {
7878
val uiState by viewModel.uiState.collectAsState()
7979
uiState.apply {
8080
when (this) {
81-
is UiState.Loaded -> LoadedState(
81+
is UiState.Loaded -> loadedState(
8282
content = this,
8383
onTermsAndConditionsClick = { viewModel.onTermsAndConditionsClick() },
8484
onInstallFullPluginClick = { viewModel.onInstallFullPluginClick() },

WordPress/src/main/java/org/wordpress/android/ui/jetpackplugininstall/fullplugin/onboarding/compose/state/LoadedState.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ import org.wordpress.android.ui.jetpackplugininstall.fullplugin.onboarding.compo
3333
import org.wordpress.android.ui.jetpackplugininstall.fullplugin.onboarding.compose.component.TermsAndConditions
3434

3535
@Composable
36-
fun LoadedState(
36+
fun loadedState(
3737
content: UiState.Loaded,
3838
onTermsAndConditionsClick: () -> Unit,
3939
onInstallFullPluginClick: () -> Unit,
@@ -118,6 +118,6 @@ private fun PreviewLoadedState() {
118118
siteUrl = "wordpress.com",
119119
pluginNames = listOf("Jetpack Search"),
120120
)
121-
LoadedState(uiState, {}, {}, {}, {})
121+
loadedState(uiState, {}, {}, {}, {})
122122
}
123123
}

0 commit comments

Comments
 (0)