Skip to content

Commit 41327b9

Browse files
authored
Extract HTMLParser in dedicated library (#1412)
Fixes https://linear.app/a8c/issue/AINFRA-639 The code is already in use in the WooCommerce iOS watchOS app, see woocommerce/woocommerce-ios@ec7a641 I decide to extract the files under the standard `Sources/` and `Tests/` root folders that SwiftPM expects. To keep the `Package.swift` and `podspec`s consistent, I moved all the other sources and tests there, too. I updated the plumbing in the example app and ran it locally to ensure it still works, for what is worth. <img alt="Screenshot 2025-06-04 at 8 12 01 AM" src="https://github.com/user-attachments/assets/c7f8fdd2-134c-4f47-9d41-aac895c12c1e" width=300/> --- - [x] I have considered if this change warrants release notes and have added them to the appropriate section in the `CHANGELOG.md` if necessary. – N.A. many files were moved, but the source change was minimal.
2 parents 8dea1ea + bd3eacc commit 41327b9

File tree

344 files changed

+393
-4033
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

344 files changed

+393
-4033
lines changed

.buildkite/shared-pipeline-vars

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
# The ~> modifier is not currently used, but we check for it just in case
77
XCODE_VERSION=$(sed -E 's/^~> ?//' .xcode-version)
8-
CI_TOOLKIT_PLUGIN_VERSION="3.8.0"
8+
CI_TOOLKIT_PLUGIN_VERSION="5.3.1"
99

10-
export IMAGE_ID="xcode-$XCODE_VERSION-macos-14.7.1-v1"
10+
export IMAGE_ID="xcode-$XCODE_VERSION"
1111
export CI_TOOLKIT_PLUGIN="automattic/a8c-ci-toolkit#$CI_TOOLKIT_PLUGIN_VERSION"

.editorconfig

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
root = true
2+
3+
# Apply to all files
4+
[*]
5+
indent_style = space
6+
indent_size = 2
7+
end_of_line = lf
8+
insert_final_newline = true
9+
charset = utf-8
10+
trim_trailing_whitespace = true
11+
12+
[*.md]
13+
trim_trailing_whitespace = false
14+
15+
[*.swift]
16+
indent_size = 4
17+
18+
[{*.h,*.m}]
19+
indent_size = 4
20+
21+
# Ruby specific rules
22+
[{*.rb,Fastfile,Gemfile}]
23+
indent_style = space
24+
indent_size = 2

.rubocop.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22
AllCops:
33
NewCops: enable
44

5+
Metrics/BlockLength:
6+
Exclude:
7+
- 'WordPress-Aztec-iOS.podspec'
8+
- 'WordPress-Editor-iOS.podspec'
9+
510
# Allow the Podspec filename to match the project
611
Naming/FileName:
712
Exclude:

.swiftpm/xcode/xcshareddata/xcschemes/Aztec.xcscheme

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,13 @@
2626
buildConfiguration = "Debug"
2727
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
2828
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
29-
shouldUseLaunchSchemeArgsEnv = "YES"
30-
shouldAutocreateTestPlan = "YES">
29+
shouldUseLaunchSchemeArgsEnv = "YES">
30+
<TestPlans>
31+
<TestPlanReference
32+
reference = "container:Tests/AztecTests/Aztec.xctestplan"
33+
default = "YES">
34+
</TestPlanReference>
35+
</TestPlans>
3136
</TestAction>
3237
<LaunchAction
3338
buildConfiguration = "Debug"

.swiftpm/xcode/xcshareddata/xcschemes/WordPress-AztecEditor-iOS-Package.xcscheme

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,20 @@
6262
ReferencedContainer = "container:">
6363
</BuildableReference>
6464
</BuildActionEntry>
65+
<BuildActionEntry
66+
buildForTesting = "YES"
67+
buildForRunning = "YES"
68+
buildForProfiling = "YES"
69+
buildForArchiving = "YES"
70+
buildForAnalyzing = "YES">
71+
<BuildableReference
72+
BuildableIdentifier = "primary"
73+
BlueprintIdentifier = "HTMLParser"
74+
BuildableName = "HTMLParser"
75+
BlueprintName = "HTMLParser"
76+
ReferencedContainer = "container:">
77+
</BuildableReference>
78+
</BuildActionEntry>
6579
</BuildActionEntries>
6680
</BuildAction>
6781
<TestAction
@@ -91,6 +105,16 @@
91105
ReferencedContainer = "container:">
92106
</BuildableReference>
93107
</TestableReference>
108+
<TestableReference
109+
skipped = "NO">
110+
<BuildableReference
111+
BuildableIdentifier = "primary"
112+
BlueprintIdentifier = "HTMLParserTests"
113+
BuildableName = "HTMLParserTests"
114+
BlueprintName = "HTMLParserTests"
115+
ReferencedContainer = "container:">
116+
</BuildableReference>
117+
</TestableReference>
94118
</Testables>
95119
</TestAction>
96120
<LaunchAction

.xcode-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
16.2
1+
16.4

Aztec.xcodeproj/project.pbxproj

Lines changed: 0 additions & 2241 deletions
This file was deleted.

Aztec.xcodeproj/project.xcworkspace/contents.xcworkspacedata

Lines changed: 0 additions & 11 deletions
This file was deleted.

Aztec.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist

Lines changed: 0 additions & 8 deletions
This file was deleted.

Aztec.xcodeproj/xcshareddata/xcschemes/Aztec.xcscheme

Lines changed: 0 additions & 116 deletions
This file was deleted.

0 commit comments

Comments
 (0)