-
Notifications
You must be signed in to change notification settings - Fork 122
Intercept touch event to task list checkboxes to handle it before the cursor is moved #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…id into improve-checkboxes
khaykov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @danilo04 ! It works well. Maybe we can reduce the padding to 15, what do you think?
I also have a suggestion for preserving a cursor. Let me know what do you think :)
| x, | ||
| totalPaddingStart | ||
| ) == true) { | ||
| refreshText() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a whole bunch of code here that was supposed to preserve a cursor, but the only thing that was actually doing was just passing false into refreshText.
| refreshText() | |
| refreshText(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Man, that is what happens when you don't read the method's signature. Thank you for the pointer.
|
Thank you for the recommendation @khaykov, I implemented both changes. |
khaykov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Fix
This PR improves the UX of task lists checkboxes touch events. The changes are a little hacky but that is how the current solution to work with checkboxes work currently.
Test
Review
@planarvoid
Make sure strings will be translated:
strings.xmlas a part of the integration PR.