Skip to content

Commit 67c07fd

Browse files
committed
Deps: Replace androidx legacy support v4 dependency in aztec
Although removing the 'androidx.legacy.support.v4' is enough by itself and the build is (almost) not failing, it is better to also replace that with 'androidx.collection' due to this 'androidx.collection.ArrayMap' import on 'AztecQuoteSpan'. FYI: It got introduced as part of this (ad68cc9) commit, a part of the AndroidX migration. PS: To make sure that the build is not failing the only instance of 'androidx.legacy', the '<androidx.legacy.widget.Space/>' got replaced with '<Space/>' on the 'aztec_format_bar_advanced.xml' view. ------------------------------------------------------------------------ This replacement was suggested by the dependency analysis report, see below: Advice for :aztec Unused dependencies which should be removed: implementation 'androidx.legacy:legacy-support-v4:1.0.0' These transitive dependencies should be declared directly: ... implementation 'androidx.collection:collection:1.1.0' ... implementation 'androidx.legacy:legacy-support-core-ui:1.0.0' ...
1 parent a394608 commit 67c07fd

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

aztec/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ dependencies {
5252
implementation "org.ccil.cowan.tagsoup:tagsoup:$tagSoupVersion"
5353
implementation "org.jsoup:jsoup:$jSoupVersion"
5454

55-
implementation 'androidx.legacy:legacy-support-v4:1.0.0'
55+
implementation 'androidx.collection:collection:1.1.0'
5656
implementation 'com.google.android.material:material:1.0.0'
5757

5858
implementation "org.wordpress:utils:$wordpressUtilsVersion"

aztec/src/main/res/layout/aztec_format_bar_advanced.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@
118118

119119
</RelativeLayout>
120120

121-
<androidx.legacy.widget.Space
121+
<Space
122122
android:layout_width="0dp"
123123
android:layout_height="wrap_content"
124124
android:layout_weight="1"/>

0 commit comments

Comments
 (0)