Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update highlight.js version to pickup release fixing memory leak #60

Closed
callie-openai opened this issue Sep 30, 2024 · 8 comments
Closed

Comments

@callie-openai
Copy link

https://github.com/highlightjs/highlight.js/blob/main/CHANGES.md#version-11110 was just released and the package.json for highlight won't pick up the minor version bump to 11.11.0. Can we bump this (and potentially use ^11.11.0 so these can get picked up w/out re-release in the future?

Also happy to open a PR if that would help.

@wooorm
Copy link
Owner

wooorm commented Oct 1, 2024

^ doesn’t work well because we use the internals — that sometimes breaks.

@joshgoebel I am watching GH releases but hadn’t seen this one yet; perhaps you still meant to do that?

@wooorm
Copy link
Owner

wooorm commented Oct 1, 2024

@callie-openai The version you refer to isn’t on npm yet. It is not released yet. I think Josh describes the upcoming release in changed.md too.

@callie-openai
Copy link
Author

@wooorm Sadly I realized that's correct, it is updated on the Changelog but not actually published yet. I'm not sure why, that seems unexpected. I'll keep monitoring and re-ping if I see it before you.

@urmauur
Copy link

urmauur commented Nov 26, 2024

FYI, I saw this on 11.10.0: highlightjs/highlight.js#4095. Should Lowlight update highlight.js to version 11.10.0? Here’s the comparison: https://github.com/highlightjs/highlight.js/compare/11.10.0…main.

@wooorm
Copy link
Owner

wooorm commented Nov 26, 2024

Not sure what you are saying. It already is on 11.10 https://github.com/wooorm/lowlight/blob/main/package.json?

@wooorm
Copy link
Owner

wooorm commented Nov 26, 2024

oh looks like that was never released

@wooorm
Copy link
Owner

wooorm commented Nov 26, 2024

https://github.com/wooorm/lowlight/releases/tag/3.2.0 — could someone confirm if this issue is solved or can still be reproduced? Thanks

@wooorm
Copy link
Owner

wooorm commented Nov 27, 2024

closing, I think this is solved

@wooorm wooorm closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants