HashTable Implemented

[khanrn]

All Submissions:

• Have you followed the WooCommerce Contributing guideline?
• Does your code follow the WordPress' coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Here I've used HashTable to achieve the same output as achieved bystr(i)pos. Here HashTable is more efficient.

Closes this below comment-

// TODO: Fix conditional to only include shipping/billing address fields in a smarter way without str(i)pos. 

Reference:

https://stackoverflow.com/a/4106654/2740232

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[kloon]

Good first shot, although I find it a bit messy and dificult to read, you can do the first check with preg_match on /shipping_|billing_/ and then keep the in_array check on the nested if.

[khanrn]

But @kloon we are doing this inside of a foreach loop, means frequently or on multiple fields. So, I think for this issue preg_match and in_array will be more time and resource consuming than checking an array element after explode.
Lastly, with all due respect I disagree that this is less readable. 🙂 The previous version seemed to me much complected to read and understand.

[kloon]

@rnaby I did not imply it is less readable than what we currently have, was referring to all the nested function calls within each other. With regex you can achieve that in one if statement and not two like this

if ( preg_match( '/shipping_|billing_/', $key ) && ! in_array( $key, array( 'shipping_method', 'shipping_total', 'shipping_tax' ), true ) ) {

Speed wise, yes the regex will be slower, but we are talking about a 0.03ms difference across the whole loop which is pretty much negligible, yes I wrote a script to test this actually.

Anyway, thanks for the contribution, will approve and merge as is.