[Analytics Hub] Create shared set of stats helpers for My Store and Analytics Hub #8175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8149
Description
This PR moves a number of stats data helpers from the
StoreStatsPeriodViewModel(used for My Store stats) to a separateStatsV4DataHelperclass, so they can be reused in the Analytics Hub.It also adds a new helper related to the new Average Order Value stat that will be used in Analytics Hub.
Changes
StoreStatsPeriodViewModeltoStatsV4DataHelper.StatsV4DataHelper.createAverageOrderValueText(orderStats:currencyFormatter:currencyCode:).Testing
This PR refactors the helpers but there should be no change in the current behavior:
Note: This PR removes some redundant view model unit tests, because the logic is now contained in the helper class. However, you can undo the changes from 466c36f and run the tests in
StoreStatsPeriodViewModelTeststo confirm that all of the previous tests are still passing with these changes.Submitter Checklist
Update release notes:
RELEASE-NOTES.txtif necessary.