update tests to get rid of timeout

Author: iamgabrielma

WooCommerce/WooCommerceTests/POS/Mocks/MockPointOfSaleOrderController.swift

@@ -33,21 +33,11 @@ final class MockPointOfSaleOrderController: PointOfSaleOrderControllerProtocol {
     }
 
     var clearOrderWasCalled: Bool = false
-    private var clearOrderContinuation: CheckedContinuation<Void, Never>?
+    var onClearOrderCalled: () -> Void = {}
 
     func clearOrder() async {
         clearOrderWasCalled = true
-        await withCheckedContinuation { continuation in
-            clearOrderContinuation = continuation
-            // Resume immediately to simulate completion
-            continuation.resume()
-        }
-    }
-
-    func waitForClearOrder() async {
-        while !clearOrderWasCalled {
-            try? await Task.sleep(nanoseconds: 1_000_000)
-        }
+        onClearOrderCalled()
     }
 
     var sendReceiptErrorToThrow: Error?

WooCommerce/WooCommerceTests/POS/Models/PointOfSaleAggregateModelTests.swift

@@ -213,14 +213,18 @@ struct PointOfSaleAggregateModelTests {
                 cardPresentPaymentService: cardPresentPaymentService,
                 orderController: orderController,
             )
-
             sut.addToCart(makePurchasableItem())
 
-            // When
-            sut.startNewCart()
+            await withCheckedContinuation { continuation in
+                orderController.onClearOrderCalled = {
+                    continuation.resume()
+                }
+
+                // When
+                sut.startNewCart()
+            }
 
             // Then
-            await orderController.waitForClearOrder()
             #expect(orderController.clearOrderWasCalled == true)
         }
 
@@ -323,14 +327,18 @@ struct PointOfSaleAggregateModelTests {
                 itemsController: itemsController,
                 cardPresentPaymentService: cardPresentPaymentService,
                 orderController: orderController)
-
             sut.addToCart(makePurchasableItem())
 
-            // When
-            sut.pointOfSaleClosed()
+            await withCheckedContinuation { continuation in
+                orderController.onClearOrderCalled = {
+                    continuation.resume()
+                }
+
+                // When
+                sut.pointOfSaleClosed()
+            }
 
             // Then
-            await orderController.waitForClearOrder()
             #expect(orderController.clearOrderWasCalled == true)
             #expect(cardPresentPaymentService.cancelPaymentCalled == true)
         }