Skip to content

Commit 366c975

Browse files
committed
Move Kingfisher from CocoaPods to Modules
1 parent ae9f0bc commit 366c975

File tree

8 files changed

+26
-8
lines changed

8 files changed

+26
-8
lines changed

Modules/Package.resolved

Lines changed: 10 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Modules/Package.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ let package = Package(
4444
.package(url: "https://github.com/krzysztofzablocki/Inject.git", revision: "1.1.1"),
4545
.package(url: "https://github.com/markiv/SwiftUI-Shimmer", from: "1.0.0"),
4646
.package(url: "https://github.com/nalexn/ViewInspector", from: "0.10.0"),
47+
.package(url: "https://github.com/onevcat/Kingfisher", from: "7.6.2"),
4748
.package(url: "https://github.com/pavolkmet/ScrollViewSectionKit", from: "1.2.0"),
4849
.package(url: "https://github.com/Quick/Nimble.git", from: "13.0.0"),
4950
.package(url: "https://github.com/simibac/ConfettiSwiftUI.git", from: "1.0.0"),
@@ -253,6 +254,7 @@ enum XcodeSupport {
253254
.product(name: "Gridicons", package: "Gridicons-iOS"),
254255
.product(name: "Inject", package: "Inject"),
255256
.product(name: "KeychainAccess", package: "KeychainAccess"),
257+
.product(name: "Kingfisher", package: "Kingfisher"),
256258
.product(name: "ScrollViewSectionKit", package: "ScrollViewSectionKit"),
257259
.product(name: "Shimmer", package: "SwiftUI-Shimmer"),
258260
.product(name: "StripeTerminal", package: "stripe-terminal-ios"),

Podfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ target 'WooCommerce' do
6565
# External Libraries
6666
# ==================
6767
#
68-
pod 'Kingfisher', '~> 7.6.2'
6968
pod 'Wormholy', '~> 1.6.6', configurations: ['Debug']
7069

7170
# Unit Tests

Podfile.lock

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
PODS:
2-
- Kingfisher (7.6.2)
32
- WordPress-Aztec-iOS (1.19.10)
43
- WordPress-Editor-iOS (1.19.10):
54
- WordPress-Aztec-iOS (= 1.19.10)
@@ -9,7 +8,6 @@ PODS:
98
- WPMediaPicker (1.8.12)
109

1110
DEPENDENCIES:
12-
- Kingfisher (~> 7.6.2)
1311
- WordPress-Editor-iOS (~> 1.19)
1412
- WordPressShared (~> 2.1-beta)
1513
- WordPressUI (~> 1.15)
@@ -18,7 +16,6 @@ DEPENDENCIES:
1816

1917
SPEC REPOS:
2018
trunk:
21-
- Kingfisher
2219
- WordPress-Aztec-iOS
2320
- WordPress-Editor-iOS
2421
- WordPressShared
@@ -27,14 +24,13 @@ SPEC REPOS:
2724
- WPMediaPicker
2825

2926
SPEC CHECKSUMS:
30-
Kingfisher: 6c5449c6450c5239166510ba04afe374a98afc4f
3127
WordPress-Aztec-iOS: 8eaa928fb3a5694924ed3befac64beaae5656e12
3228
WordPress-Editor-iOS: 98ce1fc542c3a09e48ddc9423405b1d1e48240f1
3329
WordPressShared: 0aa459e5257a77184db87805a998f447443c9706
3430
WordPressUI: 700e3ec5a9f77b6920c8104c338c85788036ab3c
3531
Wormholy: 09da0b876f9276031fd47383627cb75e194fc068
3632
WPMediaPicker: e9eaa804e1b0288d7969776608053ae0ea2941f2
3733

38-
PODFILE CHECKSUM: 8804273eb0cc5d8b404cb1b9dad2e60640bd5529
34+
PODFILE CHECKSUM: a638f0872dc55648ed9f9dbbbafd7a7c1e8a50c2
3935

4036
COCOAPODS: 1.16.2

WooCommerce.xcworkspace/xcshareddata/swiftpm/Package.resolved

Lines changed: 10 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

WooCommerce/WooCommerceTests/Mocks/MockImageCache.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import UIKit
12
@testable import Kingfisher
23

34
final class MockImageCache: ImageCache {

WooCommerce/WooCommerceTests/Mocks/MockKingfisherImageDownloader.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import UIKit
12
@testable import Kingfisher
23

34
final class MockKingfisherImageDownloader: Kingfisher.ImageDownloader {

WooCommerce/WooCommerceTests/Tools/DefaultImageServiceTests.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import UIKit
12
import XCTest
23

34
@testable import WooCommerce

0 commit comments

Comments
 (0)