-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fixes issue #292 and the uniqueID method #1001
Conversation
This fix breaks touch events for the slider. |
In what way? Touching and swiping seems to work fine here on Android/Chrome and iOS/Safari. |
Tested on Android 4.3.1 native browser and OSX/Chrome |
Ok I just tested on a Nexus 4 with CM10.2 (Android 4.3.1) native browser and that works for me. Not sure how touch events would work on OSX/Chrome..? I tried dragging the images around on the examples here to no avail: http://flexslider.woothemes.com (on OSX/Chrome 32.0.1700.102). |
thanks for the input, i'll throw together a test over the weekend to show the issue. |
Oh, thanks for the tip, just tried the emulation features in Chrome Canary, very cool :) But when emulating a Nexus 4 the touch still works for me (albeit a bit quirky compared to a real device - it doesn't snap to the correct image (in the official version or with my fix)). If you can create a test to show the issue that would be great! |
@Reec sorry for not testing this earlier, your solution works by default, it was my setup that was causing issues. |
Glad to hear it! Now let's hope someone gets around to merging this at some point. |
This looks good. Can you update this pull request to suit the current code? That way I can give you credit for this one. |
Multiple clones were added for no apparent reason. Also uniqueID only fixed the id's of sub elements due to the use of find().
Ok, I reset everything and applied the fix manually again. Should be good to go. Nice to see some work being done on this again! |
Fixes issue #292 and the uniqueID method
Thanks for this, @Reec! |
Oh right, if you didn't notice, I didn't update the minified version so you might want to do that. |
Multiple clones were added for no apparent reason. Also uniqueID only
fixed the id's of sub elements due to the use of find().