Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python binary copies being shipped due to venv sed code pattern #38252

Open
dannf opened this issue Dec 23, 2024 · 2 comments
Open

python binary copies being shipped due to venv sed code pattern #38252

dannf opened this issue Dec 23, 2024 · 2 comments
Labels

Comments

@dannf
Copy link
Contributor

dannf commented Dec 23, 2024

I ran across 2 packages last week that were using a similar code pattern that resulted in apks shipping and using copies of the installed python interpreter. Here's an example:

cce8c0e

This obviously impacts the size of packages and images, but it may also result in security vulnerabilities in those binary copies not being patched.

@dannf dannf added the eng:os label Dec 23, 2024
@dannf
Copy link
Contributor Author

dannf commented Dec 23, 2024

I also recommend that, while updating these, we make sure that the sed is restricted to operating on the first line of these files. I fear weird problems may occur later in the file.

@dannf
Copy link
Contributor Author

dannf commented Dec 23, 2024

@smoser suggested implementing a pipeline to alter sh(e)bangs in a uniform way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant