Fix regression due to warden session scope usage #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erencing non-default scopes);
…(conflicting with authenticate_admin! callback in admin_posts controller);
strouptl
force-pushed
the
warden_session_fix
branch
from
88cb49f to
b521515
Compare
|
Great you realized this as I only use one scope |
|
You don't need to update changelog for unreleased things. I'll rewrite it to be a single version announcement. |
|
Cool. I'll rebase the other branches. |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@strzibny, I discovered that there was an issue with my usage of warden session for the refresh credentials functionality: you have to pass the scope explicitly to session (e.g. warden.session(:user)), or else it resorts to the default scope. This causes problems when there is more than one model which utilizes devise-otp (e.g. User and Admin).
I have resolved this issue, and created a CHANGELOG with the details (excerpted below). All tests are passing.
Details: