-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Super Quick Info group separators #244
Comments
Hi, @IneedHelp you are welcome. @fitdev, could you take the trouble commenting on this. |
I am not 100% sure what exactly is meant by @IneedHelp , but if borders / extra padding is what is meant, then personally I do not think it's a good idea to do it in all logical sections, as it will lead to too much visual distraction in some cases (like too many horizontal lines / rectangles). It may make sense to perhaps add just horizontal line separators to visually split the tooltip into header, body, and footer (although how these sections should be defined is up to one's preference). On a related note about information presentation in Super Quick Infos, perhaps the returns subsection of the signature of a member can be improved by including information about |
Thank you for your comments, @fitdev. As for the |
Yes, sorry. I should have clarified. I meant moving the |
I admit that there's redundant "sections/rectangles" presented in the screenshot, but that's due to the mixing of ReSharper's EnhancedToolTip with Codist's Super Quick Info, but what I really meant is the option of introducing some sort of separation between major sections or very distinct sections of the presented information. |
Personally, I don't like the dimming. Perhaps indentation by 1 icon space would be better? But then I am ok with the current presentation. |
I am aware that the way information is presented is very much a matter of preference, that's why I suggested this addition as an option users can choose to enable. I should say that many of my preferences are tightly tied to Enhanced ToolTips which I've been using on top of Codist for years, and now making the decision to ditch Enhanced ToolTips, I get a brain itch whenever I notice the differences. Similarly to @fitdev , I wouldn't use the dimming (although that could represent an option for someone who does or might); I particularly like the dashed line/border for section separation: |
It may be, but it takes time to implement.
I've already tried that. I don't like so many lines there. On the contrary to #216, which triggered my same pain when working with the Quick Info and eventually I made up my mind to redesign the representation from scratch with @fitdev and @laicasaane (in #214), actually I am feeling OK with the current implementation, thus I don't want to take any time to change it at this moment. I am dealing with the nasty #227 which turns out to be unfixed, which may frustrate some users. And #245 is more worthy of investigation. |
I think its a matter of preference... |
I am sorry that I can not come up with a better design. If anyone has a better idea, please post it here. A conceptual screenshot will be nice. |
@fitdev I just tried that. It does not look good to me. It wasted some display space. |
I understand that you want to show up as much info as possible in the tooltip. But please understand that much info is not usable if you can not read it. So i made a little draft how i would do it... So
Regarding the identation inside sections...I have several proposals
Finally, i want to say that you did great work. I appreciate it but it have to be adjusted. Also i just propose things. it is not mandatory to do it. Also all of my proposals can be made optional with settings. |
I agree. Current design seems better. |
As for @DimitarCC 's suggestions:
I agree that this would be nice.
Existing design works fine for me, but if I had to pick one of the 3 suggested alternatives, I would go with 3. I am not so sure personally about other suggestions - it is really a matter of preference. I am ok with the current design - perhaps it is not the best, but it is functional enough. I don't like the idea of alignment because it indeed wastes a lot of space, and in a way makes it more difficult to read. However maybe some horizontal spacing between major sections may be increased a bit (by a few pixels). |
For me is very difficult to read because different sections are too near. No only major sections. |
@fitdev
@DimitarCC
#37 has a long discussion on this. And the current implementation is the best I can do. |
For me is very dificult to read because different sections are too near. No only major sections.
Please make more space also between description and returns and so on. |
P.S. what is required to build the extension myself? |
Install the Visual Studio Extension Development workload will do.
The Quick Info hacking code is in QuickInfo\QuickInfoOverrider.cs. |
@wmjordan |
The XML Doc part is done by the OverrideDocumentation method in QuickInfo\CSharpQuickInfo.cs. If you are unhappy with the |
Perhaps, there could be 2 styles for Super Quick Infos to accommodate users with varying preferences: the current one (called default / condensed), and the new one (with more space around different sections)? Another thing, sorry to mention it here, as it is not related to the issue, but regarding the XML Docs in Super Quick Infos, is it possible to render member symbols in a distinguished style from the rest of the text and prefix them with their containing type:
|
Hmm, it is possible.
Technically, it is easy to implement that. |
My case is the opposite, as I work with literally 1000s of different types that may have same member names, and I cannot possibly remember which type a particular member likely refers too. So, perhaps this should be an option. Also, VS's default behavior is to show the containing type. |
@DimitarCC |
@wmjordan |
Well then. Not bad to me either. |
Regarding diagnostics classification there is diagnostics service in roslyn that can be get from workspace. GetService(...). Cant you use that to get properly the analyzers issues? |
There's an new beta for download. |
This issue will be closed as improvements have been done to the recent beta versions. |
Hello! Big fan of your extension, it's a wonderful tool.
I'm wondering if it would be possible to add an option for Super Quick Info groups to be visually separated similar to this style:
It looks this way because I am using your extension combined with Enhanced ToolTips from ReSharper (which unfortunately is conflicting with Super Quick Info in the sense that it doesn't allow interacting with it).
The text was updated successfully, but these errors were encountered: