Skip to content

Commit 20822d8

Browse files
manickimanicki
authored
Merge pull request #41 from wmde/fix_eslint
Fix eslint errors on tests
2 parents 87a4548 + c4b3a9e commit 20822d8

38 files changed

+114
-152
lines changed

‎.eslintignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
vendor/**

‎.jshintrc

Lines changed: 0 additions & 37 deletions
This file was deleted.

‎tests/.eslintrc.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
"qunit": true
55
},
66
"rules": {
7-
"array-bracket-spacing": "off",
8-
"dot-notation": "off",
9-
"space-unary-ops": "off"
7+
"dot-notation": "off"
108
}
119
}

‎tests/Deserializers/ClaimDeserializer.tests.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,17 +26,17 @@ var testSets = [
2626
property: 'P1'
2727
},
2828
qualifiers: {
29-
P1: [{
29+
P1: [ {
3030
snaktype: 'novalue',
3131
property: 'P1'
32-
}]
32+
} ]
3333
},
34-
'qualifiers-order': ['P1'],
34+
'qualifiers-order': [ 'P1' ],
3535
type: 'claim'
3636
},
3737
new wb.datamodel.Claim(
3838
new wb.datamodel.PropertyNoValueSnak( 'P1' ),
39-
new wb.datamodel.SnakList( [new wb.datamodel.PropertyNoValueSnak( 'P1' )] ),
39+
new wb.datamodel.SnakList( [ new wb.datamodel.PropertyNoValueSnak( 'P1' ) ] ),
4040
'Q1$1'
4141
)
4242
]

‎tests/Deserializers/EntityDeserializer.tests.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ var defaults = [
4040
fingerprint: {
4141
labels: { en: { language: 'en', value: 'label' } },
4242
descriptions: { en: { language: 'en', value: 'description' } },
43-
aliases: { en: [{ language: 'en', value: 'alias' }] }
43+
aliases: { en: [ { language: 'en', value: 'alias' } ] }
4444
},
4545
statementGroupSet: {
4646
P1: [ {
@@ -57,7 +57,7 @@ var defaults = [
5757
fingerprint: new wb.datamodel.Fingerprint(
5858
new wb.datamodel.TermMap( { en: new wb.datamodel.Term( 'en', 'label' ) } ),
5959
new wb.datamodel.TermMap( { en: new wb.datamodel.Term( 'en', 'description' ) } ),
60-
new wb.datamodel.MultiTermMap( { en: new wb.datamodel.MultiTerm( 'en', ['alias'] ) } )
60+
new wb.datamodel.MultiTermMap( { en: new wb.datamodel.MultiTerm( 'en', [ 'alias' ] ) } )
6161
),
6262
statementGroupSet: new wb.datamodel.StatementGroupSet( [
6363
new wb.datamodel.StatementGroup( 'P1', new wb.datamodel.StatementList( [
@@ -102,7 +102,7 @@ var testSets = [
102102
'Q1',
103103
defaults[1].fingerprint,
104104
defaults[1].statementGroupSet,
105-
new wb.datamodel.SiteLinkSet( [new wb.datamodel.SiteLink( 'someSite', 'page' )] )
105+
new wb.datamodel.SiteLinkSet( [ new wb.datamodel.SiteLink( 'someSite', 'page' ) ] )
106106
)
107107
]
108108
];

‎tests/Deserializers/FingerprintDeserializer.tests.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ var testSets = [
1919
{
2020
labels: { en: { language: 'en', value: 'label' } },
2121
descriptions: { en: { language: 'en', value: 'description' } },
22-
aliases: { en: [{ language: 'en', value: 'alias' }] }
22+
aliases: { en: [ { language: 'en', value: 'alias' } ] }
2323
},
2424
new wb.datamodel.Fingerprint(
2525
new wb.datamodel.TermMap( { en: new wb.datamodel.Term( 'en', 'label' ) } ),
2626
new wb.datamodel.TermMap( { en: new wb.datamodel.Term( 'en', 'description' ) } ),
27-
new wb.datamodel.MultiTermMap( { en: new wb.datamodel.MultiTerm( 'en', ['alias'] ) } )
27+
new wb.datamodel.MultiTermMap( { en: new wb.datamodel.MultiTerm( 'en', [ 'alias' ] ) } )
2828
)
2929
]
3030
];

‎tests/Deserializers/ItemDeserializer.tests.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ var defaults = [
1212
fingerprint: {
1313
labels: { en: { language: 'en', value: 'label' } },
1414
descriptions: { en: { language: 'en', value: 'description' } },
15-
aliases: { en: [{ language: 'en', value: 'alias' }] }
15+
aliases: { en: [ { language: 'en', value: 'alias' } ] }
1616
},
1717
statementGroupSet: {
1818
P1: [ {
@@ -29,7 +29,7 @@ var defaults = [
2929
fingerprint: new wb.datamodel.Fingerprint(
3030
new wb.datamodel.TermMap( { en: new wb.datamodel.Term( 'en', 'label' ) } ),
3131
new wb.datamodel.TermMap( { en: new wb.datamodel.Term( 'en', 'description' ) } ),
32-
new wb.datamodel.MultiTermMap( { en: new wb.datamodel.MultiTerm( 'en', ['alias'] ) } )
32+
new wb.datamodel.MultiTermMap( { en: new wb.datamodel.MultiTerm( 'en', [ 'alias' ] ) } )
3333
),
3434
statementGroupSet: new wb.datamodel.StatementGroupSet( [
3535
new wb.datamodel.StatementGroup( 'P1', new wb.datamodel.StatementList( [
@@ -61,7 +61,7 @@ var testSets = [
6161
'Q1',
6262
defaults[1].fingerprint,
6363
defaults[1].statementGroupSet,
64-
new wb.datamodel.SiteLinkSet( [new wb.datamodel.SiteLink( 'someSite', 'page' )] )
64+
new wb.datamodel.SiteLinkSet( [ new wb.datamodel.SiteLink( 'someSite', 'page' ) ] )
6565
)
6666
]
6767
];

‎tests/Deserializers/MultiTermDeserializer.tests.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ QUnit.module( 'wikibase.serialization.MultiTermDeserializer' );
99

1010
var testSets = [
1111
[
12-
[{ language: 'en', value: 'test1' }, { language: 'en', value: 'test2' }],
13-
new wb.datamodel.MultiTerm( 'en', ['test1', 'test2'] )
12+
[ { language: 'en', value: 'test1' }, { language: 'en', value: 'test2' } ],
13+
new wb.datamodel.MultiTerm( 'en', [ 'test1', 'test2' ] )
1414
]
1515
];
1616

‎tests/Deserializers/MultiTermMapDeserializer.tests.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,21 +13,21 @@ var testSets = [
1313
new wb.datamodel.MultiTermMap()
1414
], [
1515
{
16-
en: [{ language: 'en', value: 'en-test' }],
17-
de: [{ language: 'de', value: 'de-test' }]
16+
en: [ { language: 'en', value: 'en-test' } ],
17+
de: [ { language: 'de', value: 'de-test' } ]
1818
},
1919
new wb.datamodel.MultiTermMap( {
20-
en: new wb.datamodel.MultiTerm( 'en', ['en-test'] ),
21-
de: new wb.datamodel.MultiTerm( 'de', ['de-test'] )
20+
en: new wb.datamodel.MultiTerm( 'en', [ 'en-test' ] ),
21+
de: new wb.datamodel.MultiTerm( 'de', [ 'de-test' ] )
2222
} )
2323
], [
2424
{
25-
en: [{ language: 'en', value: 'en-test' }],
26-
de: [{ language: 'en', value: 'en-test' }]
25+
en: [ { language: 'en', value: 'en-test' } ],
26+
de: [ { language: 'en', value: 'en-test' } ]
2727
},
2828
new wb.datamodel.MultiTermMap( {
29-
en: new wb.datamodel.MultiTerm( 'en', ['en-test'] ),
30-
de: new wb.datamodel.MultiTerm( 'en', ['en-test'] )
29+
en: new wb.datamodel.MultiTerm( 'en', [ 'en-test' ] ),
30+
de: new wb.datamodel.MultiTerm( 'en', [ 'en-test' ] )
3131
} )
3232
]
3333
];

‎tests/Deserializers/PropertyDeserializer.tests.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ var defaults = [
1212
fingerprint: {
1313
labels: { en: { language: 'en', value: 'label' } },
1414
descriptions: { en: { language: 'en', value: 'description' } },
15-
aliases: { en: [{ language: 'en', value: 'alias' }] }
15+
aliases: { en: [ { language: 'en', value: 'alias' } ] }
1616
},
1717
statementGroupSet: {
1818
P1: [ {
@@ -29,7 +29,7 @@ var defaults = [
2929
fingerprint: new wb.datamodel.Fingerprint(
3030
new wb.datamodel.TermMap( { en: new wb.datamodel.Term( 'en', 'label' ) } ),
3131
new wb.datamodel.TermMap( { en: new wb.datamodel.Term( 'en', 'description' ) } ),
32-
new wb.datamodel.MultiTermMap( { en: new wb.datamodel.MultiTerm( 'en', ['alias'] ) } )
32+
new wb.datamodel.MultiTermMap( { en: new wb.datamodel.MultiTerm( 'en', [ 'alias' ] ) } )
3333
),
3434
statementGroupSet: new wb.datamodel.StatementGroupSet( [
3535
new wb.datamodel.StatementGroup( 'P1', new wb.datamodel.StatementList( [

‎tests/Deserializers/ReferenceDeserializer.tests.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,34 +12,34 @@ var testSets = [
1212
{
1313
hash: 'i am a hash',
1414
snaks: {
15-
P1: [{
15+
P1: [ {
1616
snaktype: 'novalue',
1717
property: 'P1'
18-
}]
18+
} ]
1919
},
20-
'snaks-order': ['P1']
20+
'snaks-order': [ 'P1' ]
2121
},
2222
new wb.datamodel.Reference(
23-
new wb.datamodel.SnakList( [new wb.datamodel.PropertyNoValueSnak( 'P1' )] ),
23+
new wb.datamodel.SnakList( [ new wb.datamodel.PropertyNoValueSnak( 'P1' ) ] ),
2424
'i am a hash'
2525
)
2626
], [
2727
{
2828
hash: 'i am a hash',
2929
snaks: {
30-
P1: [{
30+
P1: [ {
3131
snaktype: 'novalue',
3232
property: 'P1'
3333
}, {
3434
snaktype: 'somevalue',
3535
property: 'P1'
36-
}],
37-
P2: [{
36+
} ],
37+
P2: [ {
3838
snaktype: 'novalue',
3939
property: 'P2'
40-
}]
40+
} ]
4141
},
42-
'snaks-order': ['P2', 'P1']
42+
'snaks-order': [ 'P2', 'P1' ]
4343
},
4444
new wb.datamodel.Reference(
4545
new wb.datamodel.SnakList( [

‎tests/Deserializers/ReferenceListDeserializer.tests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var testSets = [
1818
'snaks-order': []
1919
}
2020
],
21-
new wb.datamodel.ReferenceList( [new wb.datamodel.Reference()] )
21+
new wb.datamodel.ReferenceList( [ new wb.datamodel.Reference() ] )
2222
], [
2323
[
2424
{

‎tests/Deserializers/SiteLinkDeserializer.tests.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ var testSets = [
1212
{
1313
site: 'site-id',
1414
title: 'page-title',
15-
badges: ['badge-1', 'badge-2']
15+
badges: [ 'badge-1', 'badge-2' ]
1616
},
17-
new wb.datamodel.SiteLink( 'site-id', 'page-title', ['badge-1', 'badge-2'] )
17+
new wb.datamodel.SiteLink( 'site-id', 'page-title', [ 'badge-1', 'badge-2' ] )
1818
]
1919
];
2020

‎tests/Deserializers/SiteLinkSetDeserializer.tests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ var testSets = [
1919
badges: []
2020
}
2121
},
22-
new wb.datamodel.SiteLinkSet( [new wb.datamodel.SiteLink( 'site', 'page' )] )
22+
new wb.datamodel.SiteLinkSet( [ new wb.datamodel.SiteLink( 'site', 'page' ) ] )
2323
]
2424
];
2525

‎tests/Deserializers/SnakListDeserializer.tests.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,30 +18,30 @@ var testSets = [
1818
], [
1919
[
2020
{
21-
P1: [{
21+
P1: [ {
2222
snaktype: 'novalue',
2323
property: 'P1'
24-
}]
24+
} ]
2525
},
2626
undefined
2727
],
28-
new wb.datamodel.SnakList( [new wb.datamodel.PropertyNoValueSnak( 'P1' )] )
28+
new wb.datamodel.SnakList( [ new wb.datamodel.PropertyNoValueSnak( 'P1' ) ] )
2929
], [
3030
[
3131
{
32-
P1: [{
32+
P1: [ {
3333
snaktype: 'novalue',
3434
property: 'P1'
3535
}, {
3636
snaktype: 'somevalue',
3737
property: 'P1'
38-
}],
39-
P2: [{
38+
} ],
39+
P2: [ {
4040
snaktype: 'novalue',
4141
property: 'P2'
42-
}]
42+
} ]
4343
},
44-
['P2', 'P1']
44+
[ 'P2', 'P1' ]
4545
],
4646
new wb.datamodel.SnakList( [
4747
new wb.datamodel.PropertyNoValueSnak( 'P2' ),

‎tests/Deserializers/StatementDeserializer.tests.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,13 @@ var testSets = [
3131
references: [ {
3232
snaks: {},
3333
'snaks-order': []
34-
}],
34+
} ],
3535
type: 'statement',
3636
rank: 'preferred'
3737
},
3838
new wb.datamodel.Statement(
3939
new wb.datamodel.Claim( new wb.datamodel.PropertyNoValueSnak( 'P1' ) ),
40-
new wb.datamodel.ReferenceList( [new wb.datamodel.Reference()] ),
40+
new wb.datamodel.ReferenceList( [ new wb.datamodel.Reference() ] ),
4141
wb.datamodel.Statement.RANK.PREFERRED
4242
)
4343
]

‎tests/Deserializers/StatementGroupDeserializer.tests.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ var testSets = [
2020
}
2121
],
2222
new wb.datamodel.StatementGroup( 'P1',
23-
new wb.datamodel.StatementList( [new wb.datamodel.Statement(
23+
new wb.datamodel.StatementList( [ new wb.datamodel.Statement(
2424
new wb.datamodel.Claim( new wb.datamodel.PropertyNoValueSnak( 'P1' ) )
25-
)] )
25+
) ] )
2626
)
2727
]
2828
];

‎tests/Deserializers/StatementGroupSetDeserializer.tests.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,14 @@ var testSets = [
3636
},
3737
new wb.datamodel.StatementGroupSet( [
3838
new wb.datamodel.StatementGroup( 'P1',
39-
new wb.datamodel.StatementList( [new wb.datamodel.Statement(
39+
new wb.datamodel.StatementList( [ new wb.datamodel.Statement(
4040
new wb.datamodel.Claim( new wb.datamodel.PropertyNoValueSnak( 'P1' ) )
41-
)] )
41+
) ] )
4242
),
4343
new wb.datamodel.StatementGroup( 'P2',
44-
new wb.datamodel.StatementList( [new wb.datamodel.Statement(
44+
new wb.datamodel.StatementList( [ new wb.datamodel.Statement(
4545
new wb.datamodel.Claim( new wb.datamodel.PropertyNoValueSnak( 'P2' ) )
46-
)] )
46+
) ] )
4747
)
4848
] )
4949
]

‎tests/Deserializers/StatementListDeserializer.tests.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ var testSets = [
2222
rank: 'normal'
2323
}
2424
],
25-
new wb.datamodel.StatementList( [new wb.datamodel.Statement(
25+
new wb.datamodel.StatementList( [ new wb.datamodel.Statement(
2626
new wb.datamodel.Claim( new wb.datamodel.PropertyNoValueSnak( 'P1' ) )
27-
)] )
27+
) ] )
2828
]
2929
];
3030

‎tests/MockEntity.tests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ var testSets = [
2121
new wb.datamodel.TermMap( { de: new wb.datamodel.Term( 'de', 'de-label' ) } ),
2222
new wb.datamodel.TermMap( { de: new wb.datamodel.Term( 'de', 'de-description' ) } ),
2323
new wb.datamodel.MultiTermMap( {
24-
de: new wb.datamodel.MultiTerm( 'de', ['de-alias'] )
24+
de: new wb.datamodel.MultiTerm( 'de', [ 'de-alias' ] )
2525
} )
2626
)
2727
]

‎tests/SerializerFactory.tests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ QUnit.test( 'registerSerializer(), newSerializerFor()', function( assert ) {
4646
);
4747

4848
assert.ok(
49-
serializerFactory.newSerializerFor( new( testSets[0].Constructor ) ).constructor
49+
serializerFactory.newSerializerFor( new ( testSets[0].Constructor ) ).constructor
5050
=== testSets[0].Serializer,
5151
'Retrieved serializer by object.'
5252
);

0 commit comments

Comments
 (0)