Skip to content

Export all datamodel constructors through one file #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2019
Merged

Export all datamodel constructors through one file #90

merged 1 commit into from
Oct 1, 2019

Conversation

jakobw
Copy link
Member

@jakobw jakobw commented Sep 30, 2019

No description provided.

AlaaSarhan
AlaaSarhan approved these changes Sep 30, 2019
View reviewed changes
Copy link
Collaborator

@AlaaSarhan AlaaSarhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, like we are adopting the pattern!

I assume that all tat is expoeted here is supposed to be public right?

@jakobw jakobw marked this pull request as ready for review October 1, 2019 09:11
@jakobw jakobw requested review from Ladsgroup and rosalieper October 1, 2019 09:11
@jakobw
Copy link
Member Author

jakobw commented Oct 1, 2019

@AlaaSarhan yes, the idea is to export everything public from that file, and in Wikibase use this as the entry point to the wikibase.datamodel resource loader module, and get rid of all the other wikibase.datamodel.[xyz] modules.

@Ladsgroup Ladsgroup merged commit f0d2a75 into master Oct 1, 2019
@Ladsgroup Ladsgroup deleted the export-all branch October 1, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlaaSarhan AlaaSarhan AlaaSarhan approved these changes

@Ladsgroup Ladsgroup Ladsgroup approved these changes

@rosalieper rosalieper Awaiting requested review from rosalieper

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakobw @AlaaSarhan @Ladsgroup