Skip to content

Commit 8bb4e0f

Browse files
tarrowjakobw
authored andcommitted
Remove Fingerprint from Entity JS datamodel
Not all entities should have fingerprints so we now remove the requirement for this
1 parent 2ee8088 commit 8bb4e0f

File tree

3 files changed

+6
-22
lines changed

3 files changed

+6
-22
lines changed

README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,12 @@ the corresponding serializer, and send back to the API.
1717

1818
## Release notes
1919

20-
### 4.1.0 (2018-06-25)
20+
### 5.0.0 (2018-07-06)
21+
* Remove references to fingerprint from Entity:
22+
* Removed `Entity.getFingerprint`
23+
* Removed `Entity.setFingerprint`
2124

25+
### 4.1.0 (2018-06-25)
2226
* Added new FingerprintableEntity class
2327
* Make Item and Property inherit from it
2428

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "wikibase-data-model",
33
"description": "JavaScript implementation of the basic Wikibase DataModel entity types and components they are made of",
4-
"version": "4.1.0",
4+
"version": "5.0.0",
55
"directories": {
66
"lib": "src",
77
"test": "tests"

src/Entity.js

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -34,33 +34,13 @@ $.extend( SELF.prototype, {
3434
*/
3535
_id: null,
3636

37-
/**
38-
* @property {wikibase.datamodel.Fingerprint}
39-
* @private
40-
*/
41-
_fingerprint: null,
42-
4337
/**
4438
* @return {string}
4539
*/
4640
getId: function() {
4741
return this._id;
4842
},
4943

50-
/**
51-
* @return {wikibase.datamodel.Fingerprint}
52-
*/
53-
getFingerprint: function() {
54-
return this._fingerprint;
55-
},
56-
57-
/**
58-
* @param {wikibase.datamodel.Fingerprint} fingerprint
59-
*/
60-
setFingerprint: function( fingerprint ) {
61-
this._fingerprint = fingerprint;
62-
},
63-
6444
/**
6545
* Returns what type of Entity this is.
6646
*

0 commit comments

Comments
 (0)