Remove weirdness from Fingerprint methods

Methods to add, set or remove terms and multiterms from a Fingerprint do
not require a language code to be passed together with the term because
the language can be derived from the term object. In the current state
there can be inconsistencies in the datamodel allowing a wrong language
code to be set for a term in another language.

Author: Benestar

src/Fingerprint.js

@@ -7,6 +7,7 @@
  * @since 1.0
  * @licence GNU GPL v2+
  * @author H. Snater < mediawiki@snater.com >
+ * @author Bene* < benestar.wikimedia@gmail.com >
  *
  * @constructor
  *
@@ -71,12 +72,11 @@ $.extend( SELF.prototype, {
 	},
 
 	/**
-	 * @param {string} languageCode
 	 * @param {wikibase.datamodel.Term} label
 	 * @return {boolean}
 	 */
-	hasLabel: function( languageCode, label ) {
-		return this._labels.hasItem( languageCode, label );
+	hasLabel: function( label ) {
+		return this._labels.hasItem( label.getLanguageCode(), label );
 	},
 
 	/**
@@ -88,23 +88,21 @@ $.extend( SELF.prototype, {
 	},
 
 	/**
-	 * @param {string} languageCode
-	 * @param {wikibase.datamodel.Term} term
+	 * @param {wikibase.datamodel.Term} label
 	 */
-	setLabel: function( languageCode, term ) {
-		if ( term.getText() === '' ) {
-			this._labels.removeItemByKey( languageCode );
+	setLabel: function( label ) {
+		if ( label.getText() === '' ) {
+			this._labels.removeItemByKey( label.getLanguageCode() );
 		} else {
-			this._labels.setItem( languageCode, term );
+			this._labels.setItem( label.getLanguageCode(), label );
 		}
 	},
 
 	/**
-	 * @param {string} languageCode
 	 * @param {wikibase.datamodel.Term} label
 	 */
-	removeLabel: function( languageCode, label ) {
-		this._labels.removeItem( languageCode, label );
+	removeLabel: function( label ) {
+		this._labels.removeItem( label.getLanguageCode(), label );
 	},
 
 	/**
@@ -130,12 +128,11 @@ $.extend( SELF.prototype, {
 	},
 
 	/**
-	 * @param {string} languageCode
 	 * @param {wikibase.datamodel.Term} description
 	 * @return {boolean}
 	 */
-	hasDescription: function( languageCode, description ) {
-		return this._descriptions.hasItem( languageCode, description );
+	hasDescription: function( description ) {
+		return this._descriptions.hasItem( description.getLanguageCode(), description );
 	},
 
 	/**
@@ -147,23 +144,21 @@ $.extend( SELF.prototype, {
 	},
 
 	/**
-	 * @param {string} languageCode
-	 * @param {wikibase.datamodel.Term} term
+	 * @param {wikibase.datamodel.Term} description
 	 */
-	setDescription: function( languageCode, term ) {
+	setDescription: function( description ) {
 		if ( term.getText() === '' ) {
-			this._descriptions.removeItemByKey( languageCode );
+			this._descriptions.removeItemByKey( description.getLanguageCode() );
 		} else {
-			this._descriptions.setItem( languageCode, term );
+			this._descriptions.setItem( description.getLanguageCode(), description );
 		}
 	},
 
 	/**
-	 * @param {string} languageCode
 	 * @param {wikibase.datamodel.Term} description
 	 */
-	removeDescription: function( languageCode, description ) {
-		this._descriptions.removeItem( languageCode, description );
+	removeDescription: function( description ) {
+		this._descriptions.removeItem( description.getLanguageCode(), description );
 	},
 
 	/**
@@ -189,12 +184,11 @@ $.extend( SELF.prototype, {
 	},
 
 	/**
-	 * @param {string} languageCode
 	 * @param {wikibase.datamodel.MultiTerm} aliases
 	 * @return {boolean}
 	 */
-	hasAliases: function( languageCode, aliases ) {
-		return this._aliases.hasItem( languageCode, aliases );
+	hasAliases: function( aliases ) {
+		return this._aliases.hasItem( aliases.getLanguageCode(), aliases );
 	},
 
 	/**
@@ -206,37 +200,16 @@ $.extend( SELF.prototype, {
 	},
 
 	/**
-	 * @param {string|wikibase.datamodel.MultiTermMap} languageCodeOrAliases
-	 * @param {wikibase.datamodel.MultiTerm} [aliases]
-	 *
-	 * @throws {Error} when passing a MultiTerm without a language code.
-	 * @throws {Error} when passing a MultiTermMap with a language code.
-	 * @throws {Error} when neither passing a MultiTerm nor a MultiTermMap object.
+	 * @param {wikibase.datamodel.MultiTerm|wikibase.datamodel.MultiTermMap} aliases
 	 */
-	setAliases: function( languageCodeOrAliases, aliases ) {
-		var languageCode;
-
-		if( typeof languageCodeOrAliases === 'string' ) {
-			languageCode = languageCodeOrAliases;
-		} else {
-			aliases = languageCodeOrAliases;
-		}
-
-		if( aliases instanceof wb.datamodel.MultiTerm ) {
-			if( !languageCode ) {
-				throw new Error( 'Language code the wb.datamodel.MultiTerm object should be set '
-					+ 'for needs to be specified' );
-			}
+	setAliases: function( aliases ) {
+		if ( aliases instanceof wb.datamodel.MultiTerm ) {
 			if ( aliases.isEmpty() ) {
-				this._aliases.removeItemByKey( languageCode );
+				this._aliases.removeItemByKey( aliases.getLanguageCode() );
 			} else {
-				this._aliases.setItem( languageCode, aliases );
+				this._aliases.setItem( aliases.getLanguageCode(), aliases );
 			}
 		} else if( aliases instanceof wb.datamodel.MultiTermMap ) {
-			if( languageCode ) {
-				throw new Error( 'Unable to handle language code when setting a '
-					+ 'wb.datamodel.MultiTermMap' );
-			}
 			this._aliases = aliases;
 		} else {
 			throw new Error( 'Aliases need to be specified as wb.datamodel.MultiTerm or '
@@ -245,11 +218,10 @@ $.extend( SELF.prototype, {
 	},
 
 	/**
-	 * @param {string} languageCode
 	 * @param {wikibase.datamodel.MultiTerm} aliases
 	 */
-	removeAliases: function( languageCode, aliases ) {
-		this._aliases.removeItem( languageCode, aliases );
+	removeAliases: function( aliases ) {
+		this._aliases.removeItem( aliases.getLanguageCode(), aliases );
 	},
 
 	/**