Simplify ValueFormatter interface, remove ValueFormatterStore #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adrianheine, this needs a description, a Phabricator ticket or a link to the relevant Gerrit patch in Wikibase.git. Otherwise I have a hard time to understand what's going on here and why. |
|
It's just removing stuff we don't use anymore after https://gerrit.wikimedia.org/r/#/c/268387/ and which wasn't that nice in the first place. |
This was referenced Jul 18, 2017
Merged
|
I rebased this now that #112 got merged. I think I'm going to just merge this myself if nobody objects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: T172916