Skip to content

Commit e829ef3

Browse files
manickithiemowmde
authored andcommitted
Merge pull request #129 from wmde/rel100
Release 0.10.0
2 parents bf493f3 + 316e5e6 commit e829ef3

File tree

5 files changed

+26
-8
lines changed

5 files changed

+26
-8
lines changed

.eslintignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,5 @@
1+
lib/jquery/**
2+
lib/qunit/**
3+
lib/require/**
14
node_modules/**
25
vendor/**

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ It contains various JavaScript related to the DataValues library.
77

88
## Release notes
99

10-
### 1.0.0 (dev)
11-
* Removed `globeCoordinate.Formatter`.
12-
* Removed the `globeCoordinate` utility class.
10+
### 0.10.0 (2017-10-06)
1311
* The library is now a pure JavaScript library.
1412
* Removed MediaWiki ResourceLoader module definitions.
13+
* Removed `globeCoordinate.Formatter`.
14+
* Removed the `globeCoordinate` utility class.
1515

1616
### 0.9.0 (2017-09-06)
1717
* Removed `valueFormatters.ValueFormatterStore`.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"datavalues",
66
"wikidata"
77
],
8+
"version": "0.10.0",
89
"repository": {
910
"type": "git",
1011
"url": "https://github.com/wmde/DataValuesJavaScript"

tests/src/valueFormatters/valueFormatters.tests.js

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,12 @@
8888
*/
8989
testFormat: function( assert ) {
9090
var formatArguments = this.getFormatArguments(),
91-
formatter = this.getInstance();
91+
formatter = this.getInstance(),
92+
requests = [];
93+
94+
// Prevent continuing with subsequent tests until all formatter procedures have
95+
// finished:
96+
var done = assert.async();
9297

9398
$.each( formatArguments, function( i, args ) {
9499
var formatInput = args[0],
@@ -144,9 +149,11 @@
144149
'Formatting ' + inputDetailMsg + 'failed: ' + errorMessage
145150
);
146151
} );
147-
148-
done();
152+
requests.push( request );
149153
} );
154+
155+
// Only continue with next test after all formatter procedures are finished:
156+
$.when.apply( null, requests ).always( done );
150157
}
151158

152159
};

tests/src/valueParsers/valueParsers.tests.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,11 @@
9595
*/
9696
testParse: function( assert ) {
9797
var parseArguments = this.getParseArguments(),
98-
parser = this.getInstance();
98+
parser = this.getInstance(),
99+
requests = [];
100+
101+
// prevent from going to next test until all parser requests are handled
102+
var done = assert.async();
99103

100104
$.each( parseArguments, function( i, args ) {
101105
var parseInput = args[0],
@@ -126,8 +130,11 @@
126130
assert.ok( false, 'parsing ' + inputDetailMsg + 'failed: ' + errorMessage );
127131
} );
128132

129-
done();
133+
requests.push( request );
130134
} );
135+
136+
// only start next test after all parser requests are handled
137+
$.when.apply( null, requests ).always( done );
131138
}
132139

133140
};

0 commit comments

Comments
 (0)