Skip to content

Commit 998efe9

Browse files
committed
Remove several methods
- GlobeCoordinate. getDecimal has not been used since a50a48e - QuantityValue.get(UpperBound|LowerBound|Amount) has not been used since fadb3ab
1 parent 85ca881 commit 998efe9

File tree

3 files changed

+3
-59
lines changed

3 files changed

+3
-59
lines changed

lib/globeCoordinate/globeCoordinate.GlobeCoordinate.js

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -107,18 +107,6 @@
107107
*/
108108
getPrecision: function() { return this._precision; },
109109

110-
/**
111-
* @return {Object}
112-
* @private
113-
*/
114-
getDecimal: function() {
115-
return {
116-
latitude: this._latitude,
117-
longitude: this._longitude,
118-
precision: this._precision
119-
};
120-
},
121-
122110
/**
123111
* Compares the object to another GlobeCoordinate object and returns whether both represent
124112
* the same information.

src/values/QuantityValue.js

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -80,15 +80,6 @@ var SELF
8080
return this;
8181
},
8282

83-
/**
84-
* Returns the amount held by this quantity, as a string in standard format.
85-
*
86-
* @return {string}
87-
*/
88-
getAmount: function() {
89-
return this._amount;
90-
},
91-
9283
/**
9384
* Returns the unit held by this quantity. Returns null in case of unit-less quantities.
9485
*
@@ -98,24 +89,6 @@ var SELF
9889
return this._unit;
9990
},
10091

101-
/**
102-
* Returns the quantity's lower boundary.
103-
*
104-
* @return {dataValues.DecimalValue|null}
105-
*/
106-
getLowerBound: function() {
107-
return this._lowerBound;
108-
},
109-
110-
/**
111-
* Returns the quantity's upper boundary.
112-
*
113-
* @return {dataValues.DecimalValue|null}
114-
*/
115-
getUpperBound: function() {
116-
return this._upperBound;
117-
},
118-
11992
/**
12093
* @inheritdoc
12194
*/

tests/lib/globeCoordinate/globeCoordinate.GlobeCoordinate.tests.js

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
QUnit.module( 'globeCoordinate.GlobeCoordinate.js' );
1010

1111
QUnit.test( 'Basic checks', function( assert ) {
12-
assert.expect( 9 );
12+
assert.expect( 8 );
1313
var c;
1414

1515
assert.throws(
@@ -59,37 +59,25 @@
5959
'http://www.wikidata.org/entity/Q2',
6060
'Verified getGlobe()'
6161
);
62-
63-
assert.deepEqual(
64-
c.getDecimal(),
65-
{ latitude: 1.5, longitude: 1.5, precision: 0.1 },
66-
'Verified getDecimal()'
67-
);
6862
} );
6963

7064
QUnit.test( 'Precision defaults to null', function( assert ) {
71-
assert.expect( 3 );
65+
assert.expect( 2 );
7266
var c = new globeCoordinate.GlobeCoordinate( { latitude: 0, longitude: 0 } );
7367

7468
assert.ok(
7569
c.getPrecision() === null,
7670
'Verified getPrecision()'
7771
);
7872

79-
assert.deepEqual(
80-
c.getDecimal(),
81-
{ latitude: 0, longitude: 0, precision: null },
82-
'Verified getDecimal()'
83-
);
84-
8573
assert.ok(
8674
c.equals( c ),
8775
'Validated equality'
8876
);
8977
} );
9078

9179
QUnit.test( 'Costum globe', function( assert ) {
92-
assert.expect( 2 );
80+
assert.expect( 1 );
9381
var c = new globeCoordinate.GlobeCoordinate( {
9482
latitude: 20,
9583
longitude: 25.5,
@@ -101,11 +89,6 @@
10189
'http://www.wikidata.org/entity/Q313',
10290
'Verified getGlobe()'
10391
);
104-
105-
assert.ok(
106-
typeof c.getDecimal().globe === 'undefined',
107-
'Verified getDecimal()'
108-
);
10992
} );
11093

11194
QUnit.test( 'Strict (in)equality', function( assert ) {

0 commit comments

Comments
 (0)