[WLR Scene] Add blur #33
Conversation
ErikReider
force-pushed
the
wlr_scene_blur
branch
from
6e7ec09
to
f86ae3e
Compare
ErikReider
force-pushed
the
wlr_scene_blur
branch
from
f86ae3e
to
ca66ef7
Compare
ErikReider
force-pushed
the
wlr_scene_blur
branch
from
1017e66
to
de4ec10
Compare
ErikReider
force-pushed
the
wlr_scene_blur
branch
2 times, most recently
from
f8a24c0
to
39756c6
Compare
ErikReider
force-pushed
the
wlr_scene_blur
branch
from
39756c6
to
7634dbf
Compare
|
An optimized blur example in tinywl wouldn't really make it that tiny and simple anymore, so skipping that :) |
Understandable, but do you mind running me through what's required on the comp side for getting this to work in scene? I'm following it along but a summary may be helpful My thinking here is that one of the main goals of scene is for compositors to easily leverage our effects in very few LOC |
So the optimized blur is a new scene node that should be inserted between regular scene trees, which would be between bottom and workspace in sways use-case. The comp is responsible for resizing the node to the desired size, which in most use-cases would be the monitor's size and coordinates. The comp is also responsible for redrawing the optimized blur by marking it as “dirty”. Sway currently redraws the blur when any background or bottom layer surface commits. So actually implementing it in a fully fledged comp doesn't require that many LOC, but adding an example in TinyWL would require adding extra non-blur related code (the extra layers and a good way of showing off the optimized blur) |
|
Optimized blur (x-ray) example in tinywl is now added. It's very simple but it works good enough to demonstrate what it does and how it works :)
Notice how only the white rectangle gets blurred 😉 |
|
Might want to merge this after 0.2? Would give us some more time to think of a better impl, especially if we get a #60 impl merged |
Sounds good to me! |
ErikReider
force-pushed
the
wlr_scene_blur
branch
from
306ed8b
to
1946043
Compare
ErikReider
force-pushed
the
wlr_scene_blur
branch
from
dcae54d
to
7d61581
Compare
include/scenefx/types/wlr_scene.h
Outdated
| /** | ||
| * Tells the renderer to re-render the optimized blur for the specified output. | ||
| * A NULL output will re-render the optimized blur on every output. | ||
| * This is very expensive so should only be called when needed. | ||
| * | ||
| * An example use would be to call this when a "static" node changes, like a | ||
| * wallpaper. | ||
| */ | ||
| void wlr_scene_optimized_blur_mark_dirty(struct wlr_scene *scene, | ||
| struct wlr_output *output); |
There was a problem hiding this comment.
It would be great if we could do this dynamically in scene and ditch this function. Considering that scene optimizes the rendering by ignoring regions below opaque regions of the nodes above, I'd bet we could flip the script on that damage tracking optimization to do this dynamically when nodes below are updated
There was a problem hiding this comment.
What SwayFX does is that the optimized blur texture only gets updated when a bottom or background layer signals a commit (updates). I'm pretty sure that it would be impossible for us to check that while also giving the comp choices on how to render this (scene doesn't know where or even if layer surfaces exist).
There was a problem hiding this comment.
Hmm - but couldn't we traverse the scene tree to find the surfaces below? whether or not it's a layer surface wouldn't be relevant. Unless the impl would have separate trees for each layer that aren't linked at all - not sure if we have one root tree that has sub trees per layer or if they exist independently
There was a problem hiding this comment.
Wouldn't iterating through the tree an extra time bring some possible performance issues?
| @@ -152,6 +156,12 @@ struct wlr_scene_shadow { | |||
| float blur_sigma; | |||
| }; | |||
|
|
|||
| /** A scene-graph node telling SceneFX to render the optimized blur */ | |||
There was a problem hiding this comment.
We should maybe write that it doesn't actually render anything onto the tree
include/scenefx/types/wlr_scene.h
Outdated
| /** | ||
| * Tells the renderer to re-render the optimized blur for the specified output. | ||
| * A NULL output will re-render the optimized blur on every output. | ||
| * This is very expensive so should only be called when needed. | ||
| * | ||
| * An example use would be to call this when a "static" node changes, like a | ||
| * wallpaper. | ||
| */ | ||
| void wlr_scene_optimized_blur_mark_dirty(struct wlr_scene *scene, | ||
| struct wlr_output *output); |
There was a problem hiding this comment.
What SwayFX does is that the optimized blur texture only gets updated when a bottom or background layer signals a commit (updates). I'm pretty sure that it would be impossible for us to check that while also giving the comp choices on how to render this (scene doesn't know where or even if layer surfaces exist).
both rectangles now seem part of the blurring, other windows are not though so just seems like a layer order thing! |
Fixes setting size of border and shadow nodes too early, leading to the optimized blur example not working with GTK4 toplevels.
Fixed by 698373b :D |
Depends on #30
Also depends on #66 for the initial shadow_node impl which the blur_node should base off of. Could potentially also add a custom_node impl for both of those effect nodes?
Todo:
Make a seperate blur_node instead of forcing it onto a scene_buffer(Will be difficult to separate the discard transparent logic, so we should wait with this)Tesing: