perf(util/gconv): add struct&field cache to improve performance for struct converting #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wln32
reviewed
Aug 14, 2024
| newFieldInfo.LastFuzzyKey.Store(field.Name) | ||
| csi.tagOrFiledNameToFieldInfoMap[tagOrFieldName] = newFieldInfo | ||
| if newFieldInfo.IsField { | ||
| // TODO 为什么只有isField才添加到fieldConvertInfos |
There was a problem hiding this comment.
因为fieldConvertInfos在最开始时是一个map，这个map在一开始就是根据结构体字段名来添加的
大概结构类似于map[字段名]字段信息，显然不能用字段的tag来当key，
对于重复字段，使用索引来存储即可，可以降低遍历次数
wln32
approved these changes
Aug 14, 2024
| StructField: field, | ||
| FieldIndexes: fieldIndexes, | ||
| ConvertFunc: csi.genFieldConvertFunc(field.Type.String()), | ||
| IsCustomConvert: csi.checkTypeHasCustomConvert(field.Type), // TODO merged to ConvertFunc? |
There was a problem hiding this comment.
应该不能合并吧，map转struct时， 打个比方A->B ,A的类型是不确定的(因为map[string]any)，只有一个B类型是确定的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.