Better error detection and reordered the log messages

Author: PagedPenguin

wled00/schedule.cpp

@@ -72,26 +72,25 @@ void checkSchedule() {
     }
 }
 
-void loadSchedule()
-{
-    if (!WLED_FS.exists(SCHEDULE_FILE)) return;
+bool loadSchedule() {
+    if (!WLED_FS.exists(SCHEDULE_FILE)) return false;
 
-    requestJSONBufferLock();  //Prevent concurrent JSON access
+    if (!requestJSONBufferLock(7)) return false;  // 🔐 Acquire lock safely
 
     File file = WLED_FS.open(SCHEDULE_FILE, "r");
     if (!file) {
         releaseJSONBufferLock();
-        return;
+        return false;
     }
 
     DynamicJsonDocument doc(4096);
     DeserializationError error = deserializeJson(doc, file);
-    file.close();  // ✅ Close file before releasing lock
+    file.close();  // ✅ Always close before releasing lock
 
     if (error) {
         DEBUG_PRINTF_P(PSTR("[Schedule] JSON parse failed: %s\n"), error.c_str());
         releaseJSONBufferLock();
-        return;
+        return false;
     }
 
     numScheduleEvents = 0;
@@ -101,11 +100,12 @@ void loadSchedule()
         scheduleEvents[numScheduleEvents++] = {
             (uint8_t)e["sm"].as<int>(), (uint8_t)e["sd"].as<int>(), // start month, day
             (uint8_t)e["em"].as<int>(), (uint8_t)e["ed"].as<int>(), // end month, day
-            (uint8_t)e["r"].as<int>(), (uint8_t)e["h"].as<int>(),   // repeat mask, hour
-            (uint8_t)e["m"].as<int>(), (uint8_t)e["p"].as<int>()    // minute, preset
+            (uint8_t)e["r"].as<int>(),  (uint8_t)e["h"].as<int>(),  // repeat mask, hour
+            (uint8_t)e["m"].as<int>(),  (uint8_t)e["p"].as<int>()   // minute, preset
         };
     }
 
     DEBUG_PRINTF_P(PSTR("[Schedule] Loaded %u schedule entries from schedule.json\n"), numScheduleEvents);
-    releaseJSONBufferLock();  // Done safely
+    releaseJSONBufferLock();  // 🔓 Unlock before returning
+    return true;
 }

wled00/schedule.h

@@ -16,5 +16,5 @@ struct ScheduleEvent {
   uint8_t presetId;
 };
 
-void loadSchedule();
+bool loadSchedule();
 void checkSchedule();