Skip to content

Commit e3a51b3

Browse files
committed
feed: Rename 'processing error' -> 'feedparser warning'
A few folks have stumbled over this one, thinking that the error message meant the feed wasn't parsed [1,2,3]. All we're actually doing is passing along a feedparser warning, so adjust our prefix accordingly and drop the level from ERROR to WARNING. Hopefully this makes it clearer that: * We still process these feeds, despite the boxo exception. If feedparser can parse the feed despite the exception, it will do so. * We probably can't fix these issues in rss2email. You need to fix them in the feed itself, or adjust feedparser to deal with the busted feed. [1]: http://article.gmane.org/gmane.mail.rss2email/168 [2]: #37 [3]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=760963 Reported-by: Arun Persaud <apersaud@lbl.gov> Reported-by: Joey Hess <joeyh@debian.org> Signed-off-by: W. Trevor King <wking@tremily.us>
1 parent d397ef6 commit e3a51b3

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

CHANGELOG

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
v3.10 (unreleased)
2+
* Change 'processing error' to 'feedparser warning'.
3+
14
v3.9 (2014-09-01)
25
* Catch and error out if a user adds a feed with a duplicate name.
36
* Split sender into both sendmail's -F and -f.

rss2email/feed.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -426,7 +426,7 @@ def _check_for_errors(self, parsed):
426426
elif parsed.bozo or exc:
427427
if exc is None:
428428
exc = "can't process"
429-
_LOG.error('processing error: {}: {}'.format(exc, self))
429+
_LOG.warning('feedparser warning: {}: {}'.format(exc, self))
430430
warned = True
431431

432432
if (not warned and

0 commit comments

Comments
 (0)