Fix panic when referencing ignored directories #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix includes two things: 1. Check for `ok` value from `ResolveRef` in `checkInternalHash`. If a value was ignored but was a valid link, it would panic as it was not found. 2. Change the behaviour of `discoverRecurse` such that it keeps all found `Document`s, but adds a new `IgnoreTest` attribute such that we can track if it should be skipped on test, but still referenced in a test. Closes wjdp#126
|
Looks like my |
|
@markmandel Thank you for this, sorry for the late action |
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix includes two things:
okvalue fromResolveRefincheckInternalHash. If a value was ignored but was a valid link, it would panic as it was not found.discoverRecursesuch that it keeps all foundDocuments, but adds a newIgnoreTestattribute such that we can track if it should be skipped on test, but still referenced in a test.Closes #126