Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip TLS verify option #123

Closed
xadcoh opened this issue May 16, 2019 · 4 comments
Closed

Skip TLS verify option #123

xadcoh opened this issue May 16, 2019 · 4 comments
Assignees
Labels

Comments

@xadcoh
Copy link

xadcoh commented May 16, 2019

Hi It's not a bug it's a feature request.

Could you please consider to add --skip-tls-verification option

You could do it with conditional against transport var (and add TLSClientConfig: &tls.Config{InsecureSkipVerify: true},):

	transport := &http.Transport{
		// Disable HTTP/2, this is required due to a number of edge cases where http negotiates H2, but something goes
		// wrong when actually using it. Downgrading to H1 when this issue is hit is not yet supported so we use the
		// following to disable H2 support:
		// > Programs that must disable HTTP/2 can do so by setting Transport.TLSNextProto ... to a non-nil, empty map.
		// See issue #49
		TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
		TLSNextProto:    make(map[string]func(authority string, c *tls.Conn) http.RoundTripper),
	}
@xadcoh xadcoh added the bug label May 16, 2019
@wjdp wjdp added feature and removed bug labels May 23, 2019
@wjdp
Copy link
Owner

wjdp commented May 23, 2019

Hi, this makes sense and should def be a config option.

@jgazeau
Copy link

jgazeau commented Jun 20, 2019

@xadcoh , @wjdp . You can check what I have done in this PR. I think it match your needs.

@wjdp
Copy link
Owner

wjdp commented Jun 20, 2019

@xadcoh @jgazeau Apologies, had my head of this project for a while. jgazeau's PR #113 should cover what's being asked for here. This is now merged on master.

@xadcoh You should find a build on here soon to try it out https://builds.htmltest.wjdp.uk/

@jgazeau
Copy link

jgazeau commented Jun 20, 2019

@wjdp No problems 😉

@wjdp wjdp self-assigned this Jan 16, 2021
@wjdp wjdp closed this as completed Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants