Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Solve some issues with markdown preview #470

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

albinmedoc
Copy link

Below fixes has been implemented

  1. Ordered list rendering correctly
  2. Unordered list rendering correctly
  3. Only remove padding of the first heading-element at top level of markdown preview
  4. Change color of code-snippet to follow the theme

@JamsRepos
Copy link
Member

Nice changes, i've tested these and they all work ass intended!

One thing to note though in regards to changing the colour of the code block, do you reckon we should be changing the colour of the WYSIWYG to the same as the colour scheme for the site? As the black background seems a bit out of place.

@albinmedoc
Copy link
Author

Please take a look if that was what you meant.

@albinmedoc
Copy link
Author

Ohh, I get it. That was not what you meant. Wait a moment.

@JamsRepos
Copy link
Member

Haha, for double confirmation it's the black here.

image

@JamsRepos
Copy link
Member

Bingo, you got it. Approved 🥳

@JamsRepos JamsRepos merged commit 2051990 into wizarrrr:develop Aug 1, 2024
2 checks passed
@albinmedoc
Copy link
Author

Bingo, you got it. Approved 🥳

You are fast at testing. Good job!

wizarr-sentry bot pushed a commit that referenced this pull request Aug 2, 2024
## [4.2.0-beta.2](v4.2.0-beta.1...v4.2.0-beta.2) (2024-08-02)

### New Features

* 🎊 Any length of invitation code ([#469](#469)) ([c850c8e](c850c8e))

### Bug Fixes

* 🐛 Solve issue reordering onboarding pages ([2f6ca87](2f6ca87))
* 🐛 Solve some issues with markdown preview ([#470](#470)) ([2051990](2051990))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants