feat(Button): add customBackground prop for custom background elements #3799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
approved these changes
Sep 4, 2025
| label="Image Background" | ||
| customBackground={ | ||
| <Image | ||
| source={{uri: 'https://picsum.photos/300'}} |
There was a problem hiding this comment.
This seems to generate a random picture every time, it can cause issues in tests (if we have or will have them)
src/components/button/index.tsx
Outdated
Comment on lines
465
to
469
| position: 'absolute', | ||
| top: 0, | ||
| left: 0, | ||
| right: 0, | ||
| bottom: 0, |
There was a problem hiding this comment.
If you use our View, you can use the absF modifier to avoid these (except the overflow).
Up to you.
src/components/button/index.tsx
Outdated
| ...others | ||
| } = this.props; | ||
| const shadowStyle = this.getShadowStyle(); | ||
| const {margins, paddings} = modifiers; | ||
| const backgroundColor = this.getBackgroundColor(); | ||
| const backgroundColor = customBackground ? 'transparent' : this.getBackgroundColor(); |
There was a problem hiding this comment.
Suggested change
| const backgroundColor = customBackground ? 'transparent' : this.getBackgroundColor(); | |
| const backgroundColor = customBackground ? undefined : this.getBackgroundColor(); |
adids1221
added a commit
that referenced
this pull request
Sep 4, 2025
#3799) * feat(Button): add customBackground prop for custom background elements * feat(ButtonScreen): add custom gradient and image background buttons examples * fix(Button): update customBackground handling and improve button styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New
customBackgroundprop to the Button component that allows users to render custom React elements as button backgrounds.This prop takes precedence over the
backgroundColor.Changelog
Button - Added
customBackgroundprop to enable custom background elementsAdditional info
N/A