Skip to content

feat(avatar): ensure minimum 48x48 hit target for better accessibility #3521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 24, 2025
Merged

feat(avatar): ensure minimum 48x48 hit target for better accessibility #3521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a846f54
feat(avatar): ensure minimum 48x48 hit target for better accessibility
devin-ai-integration[bot] Feb 19, 2025
123b8b4
fix(avatar): add hitSlop to Container component
devin-ai-integration[bot] Feb 19, 2025
3f0c608
test(avatar): add snapshot tests for accessibility changes
devin-ai-integration[bot] Feb 19, 2025
8f0ad85
test(avatar): update AvatarScreen snapshots for accessibility changes
devin-ai-integration[bot] Feb 19, 2025
2334924
test(avatar): remove component test snapshots
devin-ai-integration[bot] Feb 23, 2025
4cd616e
test(avatar): remove component test file
devin-ai-integration[bot] Feb 23, 2025
9243490
refactor(avatar): rename padding variable to be more descriptive
devin-ai-integration[bot] Feb 23, 2025
26c514f
perf(avatar): memoize hitSlop calculation
devin-ai-integration[bot] Feb 23, 2025
5113b56
refactor(avatar): rename hitSlop variable to be more descriptive
devin-ai-integration[bot] Feb 23, 2025
6f27e01
refactor(avatar): simplify hitSlop using number type
devin-ai-integration[bot] Feb 24, 2025
464b7b6
test(avatar): update snapshots for number-type hitSlop
devin-ai-integration[bot] Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions demo/src/screens/__tests__/__snapshots__/AvatarScreen.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ exports[`AvatarScreen renders screen 1`] = `
accessible={true}
collapsable={false}
focusable={true}
hitSlop={0}
onClick={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
Expand Down Expand Up @@ -208,6 +209,7 @@ exports[`AvatarScreen renders screen 1`] = `
accessible={true}
collapsable={false}
focusable={true}
hitSlop={0}
onClick={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
Expand Down Expand Up @@ -394,6 +396,7 @@ exports[`AvatarScreen renders screen 1`] = `
accessible={true}
collapsable={false}
focusable={true}
hitSlop={0}
onClick={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
Expand Down Expand Up @@ -622,6 +625,7 @@ exports[`AvatarScreen renders screen 1`] = `
accessible={true}
collapsable={false}
focusable={true}
hitSlop={0}
onClick={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
Expand Down Expand Up @@ -856,6 +860,7 @@ exports[`AvatarScreen renders screen 1`] = `
accessible={true}
collapsable={false}
focusable={true}
hitSlop={0}
onClick={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
Expand Down Expand Up @@ -1112,6 +1117,7 @@ exports[`AvatarScreen renders screen 1`] = `
accessible={true}
collapsable={false}
focusable={true}
hitSlop={4}
onClick={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
Expand Down Expand Up @@ -1368,6 +1374,7 @@ exports[`AvatarScreen renders screen 1`] = `
accessible={true}
collapsable={false}
focusable={true}
hitSlop={0}
onClick={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
Expand Down Expand Up @@ -1575,6 +1582,7 @@ exports[`AvatarScreen renders screen 1`] = `
accessible={true}
collapsable={false}
focusable={true}
hitSlop={0}
onClick={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
Expand Down Expand Up @@ -1831,6 +1839,7 @@ exports[`AvatarScreen renders screen 1`] = `
accessible={true}
collapsable={false}
focusable={true}
hitSlop={0}
onClick={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
Expand Down Expand Up @@ -2132,6 +2141,7 @@ exports[`AvatarScreen renders screen 1`] = `
accessible={true}
collapsable={false}
focusable={true}
hitSlop={0}
onClick={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
Expand Down Expand Up @@ -2319,6 +2329,7 @@ exports[`AvatarScreen renders screen 1`] = `
accessible={true}
collapsable={false}
focusable={true}
hitSlop={0}
onClick={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
Expand Down Expand Up @@ -2548,6 +2559,7 @@ exports[`AvatarScreen renders screen 1`] = `
accessible={true}
collapsable={false}
focusable={true}
hitSlop={0}
onClick={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
Expand Down Expand Up @@ -2777,6 +2789,7 @@ exports[`AvatarScreen renders screen 1`] = `
accessible={true}
collapsable={false}
focusable={true}
hitSlop={0}
onClick={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
Expand Down Expand Up @@ -2964,6 +2977,7 @@ exports[`AvatarScreen renders screen 1`] = `
accessible={true}
collapsable={false}
focusable={true}
hitSlop={0}
onClick={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
Expand Down
25 changes: 0 additions & 25 deletions src/components/avatar/__tests__/index.spec.js
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions src/components/avatar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,8 @@ const Avatar = forwardRef<any, AvatarProps>((props: AvatarProps, ref: React.Forw
onPress,
children
} = themeProps;

const hitTargetPadding = Math.max(0, (48 - size) / 2);
const {size: _badgeSize, borderWidth: badgeBorderWidth = 0} = badgeProps;
const badgeSize = _badgeSize || DEFAULT_BADGE_SIZE;

Expand Down Expand Up @@ -346,6 +348,7 @@ const Avatar = forwardRef<any, AvatarProps>((props: AvatarProps, ref: React.Forw
accessible={!_.isUndefined(onPress)}
accessibilityLabel={'Avatar'}
accessibilityRole={onPress ? 'button' : 'image'}
hitSlop={onPress ? hitTargetPadding : undefined}
{...accessibilityProps}
>
<View testID={`${testID}.container`} style={textContainerStyle}>
Expand Down