feat(checkbox/radioButton): ensure minimum 48x48 hit target for better accessibility #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…r accessibility Co-Authored-By: nitzany@wix.com <nitzany@wix.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: nitzany@wix.com <nitzany@wix.com>
Co-Authored-By: nitzany@wix.com <nitzany@wix.com>
… functions Co-Authored-By: nitzany@wix.com <nitzany@wix.com>
nitzanyiz
reviewed
Feb 19, 2025
Co-Authored-By: nitzany@wix.com <nitzany@wix.com>
nitzanyiz
reviewed
Feb 19, 2025
Co-Authored-By: nitzany@wix.com <nitzany@wix.com>
nitzanyiz
reviewed
Feb 23, 2025
Co-Authored-By: nitzany@wix.com <nitzany@wix.com>
Co-Authored-By: nitzany@wix.com <nitzany@wix.com>
nitzanyiz
reviewed
Feb 23, 2025
Co-Authored-By: nitzany@wix.com <nitzany@wix.com>
|
Please update the pr description according to our template. |
nitzanyiz
reviewed
Feb 23, 2025
|
Thank you devin. I'll take it from here. Don't respond to anything here anymore. |
nitzanyiz
reviewed
Feb 24, 2025
Inbal-Tish
reviewed
Feb 26, 2025
| @@ -257,6 +257,16 @@ class RadioButton extends PureComponent<Props, RadioButtonState> { | |||
| ); | |||
| } | |||
|
|
|||
| getAccessibleHitSlop() { | |||
| const {size = DEFAULT_SIZE} = this.props; | |||
| const verticalPadding = Math.max(0, (48 - size) / 2); | |||
There was a problem hiding this comment.
Horizontally the CheckBox takes as much room as it can so it depends on the parent
Inbal-Tish
reviewed
Feb 26, 2025
src/components/checkbox/index.tsx
Outdated
| @@ -252,8 +252,16 @@ class Checkbox extends Component<CheckboxProps, CheckboxState> { | |||
| }; | |||
| }; | |||
|
|
|||
| getAccessibleHitSlop() { | |||
| const {size = DEFAULT_SIZE} = this.props; | |||
| const hitTargetPadding = Math.max(0, (48 - size) / 2); | |||
There was a problem hiding this comment.
return Math.max(0, (48 - size) / 2);
Inbal-Tish
reviewed
Feb 26, 2025
src/components/checkbox/index.tsx
Outdated
| @@ -252,8 +252,16 @@ class Checkbox extends Component<CheckboxProps, CheckboxState> { | |||
| }; | |||
| }; | |||
|
|
|||
| getAccessibleHitSlop() { | |||
There was a problem hiding this comment.
I would make it a pure function that gets the size and returns the hitslop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the accessibility of the Checkbox and RadioButton components by ensuring a minimum hit target size of 48x48 pixels, following WCAG guidelines. The changes maintain the visual appearance while making the components more accessible for touch interactions.
Changelog
Additional info
Ticket: MADS-4591