fix: [web] svg class selector #2720
Conversation
| @@ -19,6 +19,7 @@ | |||
| "@react-native-community/netinfo": "^9.3.0", | |||
| "react": "^17.0.2", | |||
| "react-dom": "^17.0.2", | |||
| "react-native": "npm:react-native-web@0.19.4", | |||
There was a problem hiding this comment.
What's that?
Why do we need this?
| @@ -301,7 +301,13 @@ class Button extends PureComponent<Props, ButtonState> { | |||
| } else { | |||
| if (Constants.isWeb) { | |||
| return ( | |||
| <Icon style={iconStyle} tintColor={Colors.$iconDefault} source={iconSource} testID={`${testID}.icon`}/> | |||
| <Icon | |||
| id={`button_icon_${this.props.id}`} | |||
There was a problem hiding this comment.
Where the id prop is coming from?
have you declared in Button props? or in Icon component's props?
| }); | ||
| }; | ||
|
|
||
| const className = `${props?.id ?? 'svg-icon'} `; |
There was a problem hiding this comment.
maybe generate an uniq random id so each classname will have a different scope
|
Let's prioritize a complete fix for this issue, with this PR this is the result:
|
|
@mendyEdri @OrenZak |
from my side yes, we will switch to prod |
why its not relevant ? @AmitShwarts , have you done something related to that ? |
We thought this PR supposed to replace yours |
|
Hey guys, I didn't know about this PR and we merged yesterday a different PR that solves this and some more bugs in web svg image. |
Description
Changelog
Additional info