Skip to content

fixed the ts error on ExpandableOverlay dialogProps in Picker. #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2023
Merged

fixed the ts error on ExpandableOverlay dialogProps in Picker. #2677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eea9f53
fixed the ts error on ExpandableOverlay dailogProps in Picker.
adids1221 Jul 23, 2023
b452210
removed the migrateDialog prop
adids1221 Jul 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/components/picker/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ const Picker = React.forwardRef((props: PickerProps, ref) => {
// TODO: Remove migrate props and migrate code
migrate = true,
migrateTextField = true,
migrateDialog,
accessibilityLabel,
accessibilityHint,
items: propItems,
Expand Down Expand Up @@ -291,7 +290,6 @@ const Picker = React.forwardRef((props: PickerProps, ref) => {
useDialog={useWheelPicker}
modalProps={modalProps}
dialogProps={DIALOG_PROPS}
migrateDialog={migrateDialog}
expandableContent={expandableModalContent}
renderCustomOverlay={renderCustomModal ? _renderCustomModal : undefined}
onPress={onPress}
Expand Down
4 changes: 0 additions & 4 deletions src/components/picker/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,6 @@ export type PickerBaseProps = Omit<NewTextFieldProps, 'value' | 'onChange'> &
* Temporary prop required for inner text field migration
*/
migrateTextField?: boolean;
/**
* Migrate the Dialog to DialogNew (make sure you use only new props in dialogProps)
*/
migrateDialog?: boolean;
/**
* Pass for different field type UI (form, filter or settings)
*/
Expand Down