Skip to content

Fix/ demo app colors #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Fix/ demo app colors #2229

merged 1 commit into from
Aug 31, 2022

Conversation

lidord-wix
Copy link
Contributor

Description

Fix demo app colors for dark mode

Changelog

Fix demo app colors for dark mode

orientation: ['portrait', 'landscape']
backgroundColor: Colors.$backgroundDefault,
orientation: ['portrait', 'landscape'],
componentBackgroundColor: Colors.$backgroundDefault
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run the demo app and toggle to dark mode (without changing the config file)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you prevent the color change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set the right colors instead the defaults we have today

@lidord-wix lidord-wix merged commit 47757f6 into master Aug 31, 2022
@lidord-wix lidord-wix deleted the fix/demoAppColors branch September 19, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants