Skip to content

Avatar - handle SVG image (fix Android crash and red screen) #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 29, 2022

Conversation

M-i-k-e-l
Copy link
Collaborator

Description

Avatar - handle SVG image (fix Android crash and red screen)

Changelog

Avatar - handle SVG image (fix Android crash and red screen)

@M-i-k-e-l M-i-k-e-l added the Important for Next Release PR that must be included in the release version label Aug 29, 2022
@M-i-k-e-l M-i-k-e-l requested a review from ethanshar August 29, 2022 06:41
M-i-k-e-l and others added 5 commits August 29, 2022 15:16
* AnimatedImage - move from LayoutAnimation to AnimationStyle

This is done so we can stop the animation when we choose to (i.e. remove the loader).

* Fix snapshots
* Added listKey prop to flat list of wheel picker

* Fix formatting

* Change listKey format passed to FlatList

Co-authored-by: Ethan Sharabi <1780255+ethanshar@users.noreply.github.com>
@M-i-k-e-l
Copy link
Collaborator Author

@ethanshar I ended up removing SvgProps since it broke npm run build:dev (typescript in unrelated components - KeyboardTrackingView and WheelPicker (old))

@M-i-k-e-l M-i-k-e-l merged commit 2cadf61 into master Aug 29, 2022
@M-i-k-e-l M-i-k-e-l deleted the fix/avatar-handle-svg branch August 29, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Important for Next Release PR that must be included in the release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants