Skip to content

Added listKey prop to flat list of wheel picker #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 29, 2022

Conversation

Effanuel
Copy link
Contributor

Description

  • Added listKey prop to WheelPicker flatlist, so that it can be rendered inside parent flatlist

Changelog

  • Added listKey prop to FlatList of WheelPicker component

@Effanuel Effanuel enabled auto-merge (squash) August 26, 2022 13:18
@Effanuel Effanuel disabled auto-merge August 26, 2022 13:18
Copy link
Collaborator

@ethanshar ethanshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the key format a little, anyway approved

@ethanshar ethanshar enabled auto-merge (squash) August 29, 2022 12:03
@ethanshar ethanshar merged commit 5926541 into master Aug 29, 2022
M-i-k-e-l pushed a commit that referenced this pull request Aug 29, 2022
* Added listKey prop to flat list of wheel picker

* Fix formatting

* Change listKey format passed to FlatList

Co-authored-by: Ethan Sharabi <1780255+ethanshar@users.noreply.github.com>
M-i-k-e-l added a commit that referenced this pull request Aug 29, 2022
* Avatar - handle SVG image (Android crash and red screen)

* Image - handle width and height with ImageBackground

* AnimatedImage - move from LayoutAnimation to AnimationStyle (#2223)

* AnimatedImage - move from LayoutAnimation to AnimationStyle

This is done so we can stop the animation when we choose to (i.e. remove the loader).

* Fix snapshots

* Added listKey prop to flat list of wheel picker (#2215)

* Added listKey prop to flat list of wheel picker

* Fix formatting

* Change listKey format passed to FlatList

Co-authored-by: Ethan Sharabi <1780255+ethanshar@users.noreply.github.com>

* Update snapshot

* Remove SvgProps to avoid breaking tsc check

Co-authored-by: Juozas Ri <32594043+Effanuel@users.noreply.github.com>
Co-authored-by: Ethan Sharabi <1780255+ethanshar@users.noreply.github.com>
ethanshar added a commit that referenced this pull request Aug 30, 2022
* Added listKey prop to flat list of wheel picker

* Fix formatting

* Change listKey format passed to FlatList

Co-authored-by: Ethan Sharabi <1780255+ethanshar@users.noreply.github.com>
@ethanshar ethanshar deleted the ListKeyPropToWheelPicker branch April 2, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants