Fix/ ColorPalette scrolling and extra renders #2179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Aug 9, 2022
| _.times(this.props.colors.length, i => { | ||
| this.itemsRefs.current[i] = React.createRef(); | ||
| }); | ||
| setTimeout(() => { |
There was a problem hiding this comment.
Consider moving setTimeout to scrollToSelected if it's being wrapped every time
| if (scrollable && this.selectedColorIndex !== undefined && this.itemsRefs) { | ||
| const childRef = this.itemsRefs[this.selectedColorIndex]; | ||
| if (scrollable && this.selectedColorIndex !== undefined && this.itemsRefs.current) { | ||
| const childRef: any = this.itemsRefs.current[this.selectedColorIndex - 1]?.current; |
There was a problem hiding this comment.
isn't the selectedColorIndex is zero based? why the minus 1?
ethanshar
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issues:
This PR fixes the two issues.
I used a hack for the scrolling - the offset of the last added color is bad (always 10) , so I calculate the one before the last and add the extra offset.
Let me know I you have any ideas (setTimeout doesn't fix anything),
Changelog
Fix ColorPalette scrolling and extra renders