Skip to content

Infra/demo app screen #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Aug 18, 2022
Merged

Infra/demo app screen #2174

merged 22 commits into from
Aug 18, 2022

Conversation

adids1221
Copy link
Contributor

Description

Changed the demo screen app according to the new design.

Changelog

Changed the demo screen app according to the new design.

Copy link
Collaborator

@ethanshar ethanshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adids1221 Looks great, I added some comments

Moreover, we need to test this version in the private demo app before we merge it.
So let's go over it together and I'll explain how you can do that.

@adids1221 adids1221 requested a review from ethanshar August 10, 2022 14:48
@adids1221 adids1221 requested a review from ethanshar August 11, 2022 08:32
@adids1221 adids1221 requested a review from ethanshar August 17, 2022 09:15
@ethanshar
Copy link
Collaborator

@adids1221
Approved. Notice that there's a small conflict you need to fix in MainScreen.
Also, as discussed, make sure to merge it together with the private PR and update the team

@adids1221 adids1221 merged commit 761f132 into master Aug 18, 2022
@adids1221 adids1221 deleted the infra/demo_app_screen branch August 24, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants