Migrate to deprecated-react-native-prop-types package #2156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ethanshar Hey! Any chance of getting this reviewed? This is one of the blockers for using UILib with ReactNative 0.69 (or expo 0.46). |
|
ran into this error as well, please review merge so we can upgrade to 0.69 |
ethanshar
approved these changes
Aug 17, 2022
|
resolve #2159 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since version 0.68 React Native started to warn that prop types will be removed from the core and in the latest 0.69 version (see breaking change in the release notes) it happened. Which made ui-lib incompatible with latest RN.
In this PR I migrated all imports of prop types from RN to imports from
deprecated-react-native-prop-types. This package doesn't provide typings and there seem to be no@types/version of it available, so I went with// @ts-expect-errorfor imports, let me know if you prefer some other alternative (writing proper custom types seemed to be quite a huge effort).And I fixed 2 typos in markdown files.
resolves #2126
resolves #2094
Changelog
deprecated-react-native-prop-typespackage.