Create a Dialog that uses hooks #2116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Jul 24, 2022
| @@ -2,7 +2,7 @@ | |||
| import {useEffect, useCallback} from 'react'; | |||
There was a problem hiding this comment.
Btw, is it possible that we only need the useAnimatedTransition hook and don't need the actual TransitionView component anymore?
There was a problem hiding this comment.
It is possible, let me know if you want it removed, I prefer to do it in a different PR.
There was a problem hiding this comment.
Let's remove. we can do it on another PR
Effanuel
reviewed
Jul 28, 2022
ethanshar
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the
Incubator.Dialogto use (internal) hooksChangelog
Change the
Incubator.Dialogto use hooks, fixes issues with size given in percentage and not numbers