Slider - add range slider functionality #2084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onding thumb is not the active one
ethanshar
approved these changes
Jun 26, 2022
There was a problem hiding this comment.
@Inbal-Tish
Looks good.
For next time it will be helpful if the PR description have more info of the process you had here (Big changes you did, why you did them, etc...) so it's easier to review
I see the driver is kinda WIP, so feel free to merge and continue it on another PR
ethanshar
added
the
Important for Next Release
|
@Inbal-Tish |
Thanks! Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Slider - adding range slider functionality
Changelog
Slider - adding range slider functionality