Feat/sortable list no scroll #1958
Conversation
| const onLayout = useCallback((event: LayoutChangeEvent) => { | ||
| // Round height for Android | ||
| const newHeight = Math.round(event.nativeEvent.layout.height); | ||
| itemHeight.value = newHeight; | ||
| }, []); |
There was a problem hiding this comment.
I'd consider moving it to the main index file and pass the callback thru the context
It's easier to see the declaration of itemHeight and its initialization in the same file
There was a problem hiding this comment.
TBH this does not bother me, but ok.
What bothered me more is the logic index === 0 ? onItemLayout : undefined inside the item, but I was not able to move that to the list, let me know if you have a solution for that.
There was a problem hiding this comment.
In my case, what I did is pass onLayout to all items.
But save the layout only once and have any callback arriving afterwards do nothing.
There was a problem hiding this comment.
It is much simpler when using ScrollView, here we have a FlatList.
If it is possible to do it, then it's either by:
- Changing the
renderItemfunction which will look odd and might affect performance. - Do it in the
CellRendererComponentand that's not what you meant.
There was a problem hiding this comment.
Why is it matter if it's FlatList or ScrollView.
The code I suggested is in the on item layout callback
| const tempTranslateY = useSharedValue(0); | ||
| const tempItemsOrder = useSharedValue(itemsOrder.value); |
There was a problem hiding this comment.
Consider moving these to useDragAfterLongPressGesture hook.
I'd move the logic to the hook, any reason onDragStart, onDragUpdate, onDragEnd shouldn't be part of the hook's code?
There was a problem hiding this comment.
I think we should look at this hook and the one in the SortableGridList and extract a single one.
There was a problem hiding this comment.
Yes, very possible.
But I prefer to do it once the components are stable and we know for sure the logic shared between them is the same.
There was a problem hiding this comment.
So let's keep it as is? Do you want to add a task a TODO or...?
There was a problem hiding this comment.
Why not fix it? Is it a big change?
If we'll decide not to share code, the code we'll just stuck there..
Description
SortableList - a new component (scroll-while-dragging is not supported in this phase).
Changelog
SortableList - a new component (scroll-while-dragging is not supported in this phase).