ColorPalette - fix orientation change called unnecessarily (#725)

M-i-k-e-l · web-flow · commit e8cd4a21d564 · 2020-04-02T09:02:09.000+03:00
diff --git a/src/components/colorPicker/ColorPalette.js b/src/components/colorPicker/ColorPalette.js
@@ -98,8 +98,10 @@ export default class ColorPalette extends PureBaseComponent {
   }
 
   onOrientationChanged = () => {
-    this.initLocalVariables();
-    this.setState({orientation: Constants.orientation}); // only to trigger render
+    if (this.state.orientation !== Constants.orientation) {
+      this.initLocalVariables();
+      this.setState({orientation: Constants.orientation}); // only to trigger render
+    }
   }
 
   initLocalVariables() {

Original file line number	Diff line number	Diff line change
`@@ -98,8 +98,10 @@ export default class ColorPalette extends PureBaseComponent {`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`onOrientationChanged = () => {`
`101`		`- this.initLocalVariables();`
`102`		`- this.setState({orientation: Constants.orientation}); // only to trigger render`
	`101`	`+ if (this.state.orientation !== Constants.orientation) {`
	`102`	`+ this.initLocalVariables();`
	`103`	`+ this.setState({orientation: Constants.orientation}); // only to trigger render`
	`104`	`+ }`
`103`	`105`	`}`
`104`	`106`
`105`	`107`	`initLocalVariables() {`