-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[Android] Hide keyboard when view is destroyed #7295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Android] Hide keyboard when view is destroyed #7295
Conversation
Perhaps we could add an option to control if the Keyboard should dismiss or not, as I mentioned in the issue #7008 this was causing other unforeseen issues, so by adding an option that defaults to true and respecting that option we could then hide the keyboard or leave it opened. |
Btw thanks for submitting a PR ;) |
I will bow to superior knowledge here! The original patch is working well for us but I can see how it isn't a silver bullet. Perhaps this PR should be closed in favour of another? FWIW I like the |
We already making checks in our playground. and maybe adding e2e's for such cases. I already debugged that internally with our devs and found out about why |
If it helps, we saw the issue when using |
I tried to reproduce the issue without the changes mentioned here, but could not reproduce it see. Let's first reproduce the issue in a minimal environment as the guidelines state and see what is the problem itself and then we might push a fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to reproduce the bug first with a minimal code and then we might visit this solution, see my last comment
Fixes #7008
All credit here must go to @enahum, I am merely packing the changes into a PR.