Fix system & back button color#4592
Merged
Merged
Conversation
maryjenel
commented
Jan 16, 2019
| } | ||
| UIColor* color = [self color:[RCTConvert UIColor:button[@"color"]] defaultColor:[defaultStyle.color getWithDefaultValue:nil]]; | ||
| if (color) { | ||
| self.viewController.navigationController.navigationBar.tintColor = color; |
Contributor
Author
There was a problem hiding this comment.
This handles the back button tint color. If anyone has a better way of handling this, please feel free to comment :D Feedback is much appreciated :)
eliperkins
approved these changes
Jan 23, 2019
Contributor
eliperkins
left a comment
eliperkins
left a comment
There was a problem hiding this comment.
This seems good to me. It looks like we handled the case of coloring icons and text buttons, but never system buttons. 👍
yogevbd
approved these changes
Jan 24, 2019
vshkl
pushed a commit
to vshkl/react-native-navigation
that referenced
this pull request
Feb 5, 2020
* Add color to tintColor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets the system button color and back button color.
When a user sets the color to a system icon, the colors were not being applied because nothing was setting the value. The current values that were being set were text and icon based buttons, but not system buttons.