-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Content shifting up when keyboard appear #7402
Comments
We should take |
Hi @swabbass Do you know how to android consider "windowSoftInputMode" normally? You are right, we should consider this option as well. |
we might use |
Hello! I just wanted to share that I too have seen an issue with Instead my app is set to |
# Issue: Window insets does not apply when keyboard got closed in case of adjustPan, and in case of adjustNothing it will just ignore it and treat it like adjustResize. The difference between Pan and Resize as pointed [here](https://www.techrepublic.com/article/pro-tip-make-sense-of-pan-vs-resize-in-the-android-manifest/): adjustResize: The activity’s main window is always resized to make room for the soft keyboard on screen. adjustPan: The activity’s main window is not resized to make room for the soft keyboard. Rather, the contents of the window are automatically panned so that the current focus is never obscured by the keyboard and users can always see what they are typing. **This is generally less desirable than resizing, because the user may need to close the soft keyboard to get at and interact with obscured parts of the window.** # Fix: - Due to the nature of adjustPan, we need to wait for the layout to be updated after the keyboard closed, and then apply insets to determine the final state. - Take adjustNothing into consideration and don't adjust the insets. Adjust Nothing: https://user-images.githubusercontent.com/7227793/153453913-7af3fcb7-87f6-4cfa-aaf8-e2f32b023c61.mov Adjust Pan: https://user-images.githubusercontent.com/7227793/153453981-73ccf0c9-e42e-41e3-bede-8f561f9ba53a.mov AdjustPan old Androids (the white space fixed in master, which is not included in the recorded demo) https://user-images.githubusercontent.com/7227793/153454164-300c115b-9e7a-407c-b612-c0ca8ac158ea.mov **NOTE: As checked, if flags are set to adjustResize, then there is no issue at all across all versions.** Closes: #7433. Closes: #7427. Closes: #7428. Closes: #7402. Co-authored-by: Yogev Ben David <yogev132@gmail.com>
🐛 Bug Report
Content always shifting up when keyboard appears, even with setting
windowSoftInputMode
toadjustNothing
.removing
keyboardInsets
is a temporary solution but I'm not sure if it will effect other situations or not.react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/component/ComponentViewController.java
Line 146 in fb6d028
To Reproduce
(Write your steps here:)
windowSoftInputMode
toadjustNothing
Expected behavior
Keyboard visibility should NOT effect content visibility when
windowSoftInputMode
set toadjustNothing
.Your Environment
7.24.1
0.66.1
Android
Android Device running SDK 30
The text was updated successfully, but these errors were encountered: