Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Large title animation flicks with pull-to-refresh #5152

Closed
gabrielvcbessa opened this issue May 24, 2019 · 14 comments
Closed

[v2] Large title animation flicks with pull-to-refresh #5152

gabrielvcbessa opened this issue May 24, 2019 · 14 comments

Comments

@gabrielvcbessa
Copy link

gabrielvcbessa commented May 24, 2019

Related to #3538 posted in Jul 11, 2018 that is being ignored.

Large title doesn't behavior as expected when you have pull to refresh on the screen. I don't know if this is an iOS or react-native-navigation bug.

With small title:

small title

With large title:

large title bug


Environment

  • React Native Navigation version: 2.18.4
  • React Native version: 0.59
  • Platform(s) (iOS, Android, or both?): iOS
@juangamnik
Copy link

Does still occur on react native 0.59 and react navigation 2.18.4

@matpaul
Copy link

matpaul commented Jun 21, 2019

I think issue not in RNN, but in RCTScrollView,
There is a method setCustomRefreshControll in RCTScrollView
after change

[self addSubview:_customRefreshControl];
to
self.refreshControl = customRefreshControl;

flicks is gone, but pull to refresh show only once(( other offset etc logic failed after change

@stale
Copy link

stale bot commented Jul 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

@stale stale bot added the 🏚 stale label Jul 21, 2019
@chrise86
Copy link

Not stale.

@stale stale bot removed the 🏚 stale label Jul 21, 2019
@stale
Copy link

stale bot commented Aug 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

@stale stale bot added the 🏚 stale label Aug 20, 2019
@chrise86
Copy link

Still not stale.

@stale stale bot removed the 🏚 stale label Aug 20, 2019
@kneza23
Copy link

kneza23 commented Sep 9, 2019

Still not stale, really sad as we can't use large title with pull down refresh (90% of the lists have that)

@stale
Copy link

stale bot commented Oct 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

@stale stale bot added the 🏚 stale label Oct 9, 2019
@stale
Copy link

stale bot commented Oct 16, 2019

The issue has been closed for inactivity.

@stale stale bot closed this as completed Oct 16, 2019
@juangamnik
Copy link

Still not stale

@Rybachello
Copy link

not stale

@guyca
Copy link
Collaborator

guyca commented Mar 7, 2020

As part of an effort by @yogevbd to address all large title issues, he opened a PR with a fix to react-native. Hopefully it will be merged soon 🙏

@bdrobinson
Copy link

Looks like it's been merged now right? Nice one! facebook/react-native#28236 Thanks for all the efforts to get it fixed, what else needs to happen for this to work in RNN?

@guyca
Copy link
Collaborator

guyca commented Aug 12, 2020

This has been fixed by @yogevbd 's PR to react native, closing as there's nothing else to do in RNN.

@guyca guyca closed this as completed Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants