-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2] Lack of componentWillAppear/componentWillDisappear #4793
Comments
Have you by chance subscribed to navigation events in this component via something like:
|
@donovanhiland yes, I've subscribed - which gives me access to |
Hey @aafarian |
@guyca please expose componentWillDisappear event |
Issue Description
We don't have access to a componentWillAppear/componentWillDisappear in V2.
Currently, when trying to migrate onNavigatorEvent events, we can migrate "didAppear", "didDisappear", "bottomTabReselected" (although for that one we have to manually compare the current/target tab to see if they're the same).
"didAppear" --> componentDidAppear
"didDisappear" --> componentDidDisappear
"willAppear" --> ?
"willDisappear" --> ?
I'm aware that we have componentDidMount/componentDidUnmount, but those will not fire when a modal is opened/closed that was on top of your screen, whereas "didAppear" used to fire on a root page when you closed a modal on top of it and "didDisappear" will fire off when you open a modal on top of a root page.
Environment
The text was updated successfully, but these errors were encountered: