Add colored icon to BottomTabs screen

guyca · guyca · commit 81c5a926d1b6 · 2019-02-07T12:10:08.000+02:00
diff --git a/playground/src/app.js b/playground/src/app.js
@@ -32,8 +32,6 @@ function start() {
         orientation: ['portrait']
       },
       bottomTab: {
-        iconColor: '#1B4C77',
-        selectedIconColor: '#0f0',
         textColor: '#1B4C77',
         selectedTextColor: '#0f0',
         fontFamily: 'HelveticaNeue-Italic',
diff --git a/playground/src/images/colored_tab_icon@2x.png b/playground/src/images/colored_tab_icon@2x.png
diff --git a/playground/src/screens/WelcomeScreen.js b/playground/src/screens/WelcomeScreen.js
@@ -87,8 +87,7 @@ class WelcomeScreen extends Component {
                         },
                         bottomTab: {
                           text: 'Tab 1',
-                          icon: require('../images/one.png'),
-                          selectedIcon: require('../images/one.png'),
+                          icon: require('../images/colored_tab_icon.png'),
                           testID: testIDs.FIRST_TAB_BAR_BUTTON
                         }
                       }
@@ -118,6 +117,8 @@ class WelcomeScreen extends Component {
                   bottomTab: {
                     text: 'Tab 2',
                     icon: require('../images/two.png'),
+                    iconColor: '#1B4C77',
+                    selectedIconColor: '#0f0',
                     testID: testIDs.SECOND_TAB_BAR_BUTTON
                   }
                 }
@@ -138,6 +139,8 @@ class WelcomeScreen extends Component {
                   bottomTab: {
                     text: 'Tab 3',
                     icon: require('../images/one.png'),
+                    iconColor: '#1B4C77',
+                    selectedIconColor: '#0f0',
                     selectedIcon: require('../images/one.png')
                   }
                 }

Original file line number	Diff line number	Diff line change
`@@ -87,8 +87,7 @@ class WelcomeScreen extends Component {`
`87`	`87`	`},`
`88`	`88`	`bottomTab: {`
`89`	`89`	`text: 'Tab 1',`
`90`		`- icon: require('../images/one.png'),`
`91`		`- selectedIcon: require('../images/one.png'),`
	`90`	`+ icon: require('../images/colored_tab_icon.png'),`
`92`	`91`	`testID: testIDs.FIRST_TAB_BAR_BUTTON`
`93`	`92`	`}`
`94`	`93`	`}`
`@@ -118,6 +117,8 @@ class WelcomeScreen extends Component {`
`118`	`117`	`bottomTab: {`
`119`	`118`	`text: 'Tab 2',`
`120`	`119`	`icon: require('../images/two.png'),`
	`120`	`+ iconColor: '#1B4C77',`
	`121`	`+ selectedIconColor: '#0f0',`
`121`	`122`	`testID: testIDs.SECOND_TAB_BAR_BUTTON`
`122`	`123`	`}`
`123`	`124`	`}`
`@@ -138,6 +139,8 @@ class WelcomeScreen extends Component {`
`138`	`139`	`bottomTab: {`
`139`	`140`	`text: 'Tab 3',`
`140`	`141`	`icon: require('../images/one.png'),`
	`142`	`+ iconColor: '#1B4C77',`
	`143`	`+ selectedIconColor: '#0f0',`
`141`	`144`	`selectedIcon: require('../images/one.png')`
`142`	`145`	`}`
`143`	`146`	`}`