Make seconds optional in pubDate (RFC-822)#40
Open
mtthsfrdrch wants to merge 1 commit intowitochandra:masterfrom
Open
Make seconds optional in pubDate (RFC-822)#40mtthsfrdrch wants to merge 1 commit intowitochandra:masterfrom
mtthsfrdrch wants to merge 1 commit intowitochandra:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using this library with https://www.nasa.gov/rss/dyn/lg_image_of_the_day.rss, always let to
pubDatebeing null.Adjusted the RFC-822 DateTime implementation to accept time without seconds. This seems to be according to its definition: https://www.w3.org/Protocols/rfc822/#z28
Also amended tests to cover this as well as #34 😉