Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools/version]: create a new version from a spec already populated by generators #45

Open
fedeci opened this issue Apr 4, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@fedeci
Copy link
Contributor

fedeci commented Apr 4, 2022

Currently, because we are using JSON.parse to print the spec, generators and structures that are not part of JSON do not get printed correctly.

Errors found when transforming fig spec:
Before:

const generator =  {
  script: 'foo',
  postProcess: () => {}
}

// ... spec here
args: {
  generators: generator
}

After:

// ... spec here
args: {
  generators: { script: 'foo' }
}

const generator =  {
  custom: () => {}
}

// ... spec here
args: {
  generators: generator
}

After:

// ... spec here
args: {
}
@fedeci fedeci added the bug Something isn't working label Apr 4, 2022
@fedeci fedeci self-assigned this Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant